The files of /admin count against the pre-authentication rate limit

Aperta
#3,452 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
74/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
csharp
Ambito
backend, devops

Direzione di ricerca

Start with src/FluentCMS.Core/Api/Common/PreAuthRateLimitMiddleware.cs and trace how requests are classified, then inspect the admin surface’s static file routes and the related host configuration docs. Add or adjust coverage for 40 cold admin loads while confirming API and hosted page requests remain limited. Update docs/host-configuration.md to describe what the pre-authentication limit covers.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area:host type:feature

Problem

Every request to the host passes the pre-authentication limiter, by address (src/FluentCMS.Core/Api/Common/PreAuthRateLimitMiddleware.cs, lines 53 to 67), and the endpoints of the admin are FluentCMS endpoints, so they count. A cold load of the admin is about 230 requests against 6000 a minute per address (#3178, measured in the review of #3191; not measured again). An office behind one address meets 429 when some thirty people load the admin within a minute after a deploy. A-47 turns the admin on by default.

Proposal

Leave the static files of a surface out of the pre-authentication limit, or give them a limit of their own: a fingerprinted file is cached for good after the first load, and it reads nothing of the instance. index.html and config.json may stay under the limit.

Acceptance

  • Forty cold loads of the admin from one address within a minute answer no 429
  • A request to the APIs and to the hosted pages is limited as before
  • docs/host-configuration.md says what is limited

From the review of #3191 (#3178). A-46 documents FluentCms:RateLimits:PreAuth:PermitLimit until it is merged. Size: S.

Lingua principale
C#
Stelle
567
Fork
107
Merge medio
1h 19m
PR unite (30g)
353

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di fluentcms/FluentCMS

Tutte le issue di fluentcms/FluentCMS

Issue simili

Altre issue su C#

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.