The files of /admin count against the pre-authentication rate limit

Ouverte
#3,452 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
3/5
Temps estimé
1-2 jours
Accessibilité débutants
74/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
csharp
Domaine
backend, devops

Piste de recherche

Start with src/FluentCMS.Core/Api/Common/PreAuthRateLimitMiddleware.cs and trace how requests are classified, then inspect the admin surface’s static file routes and the related host configuration docs. Add or adjust coverage for 40 cold admin loads while confirming API and hosted page requests remain limited. Update docs/host-configuration.md to describe what the pre-authentication limit covers.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

area:host type:feature

Problem

Every request to the host passes the pre-authentication limiter, by address (src/FluentCMS.Core/Api/Common/PreAuthRateLimitMiddleware.cs, lines 53 to 67), and the endpoints of the admin are FluentCMS endpoints, so they count. A cold load of the admin is about 230 requests against 6000 a minute per address (#3178, measured in the review of #3191; not measured again). An office behind one address meets 429 when some thirty people load the admin within a minute after a deploy. A-47 turns the admin on by default.

Proposal

Leave the static files of a surface out of the pre-authentication limit, or give them a limit of their own: a fingerprinted file is cached for good after the first load, and it reads nothing of the instance. index.html and config.json may stay under the limit.

Acceptance

  • Forty cold loads of the admin from one address within a minute answer no 429
  • A request to the APIs and to the hosted pages is limited as before
  • docs/host-configuration.md says what is limited

From the review of #3191 (#3178). A-46 documents FluentCms:RateLimits:PreAuth:PermitLimit until it is merged. Size: S.

Langage dominant
C#
Étoiles
567
Forks
107
Merge moyen
1 h 19 min
PR mergées (30 j)
353

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de fluentcms/FluentCMS

Toutes les issues de fluentcms/FluentCMS

Issues similaires

Plus d'issues C#

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.