fix(auth): keep a link's fragment through sign-in

Aperta
  • Qualcosa non va?
#358 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
72/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
nextjs, react, typescript
Ambito
authentication, frontend

Direzione di ricerca

Start by reading src/lib/auth/redirect.ts around line 58 to see how safeNextPath already carries a fragment, then src/app/sign-in/page.tsx:58-108 to see how next is bound to the signInWithGitHub Server Function. The missing piece is in src/app/sign-in/sign-in-form.tsx: read window.location.hash and pass it with the form so the server composes path plus fragment before safeNextPath, keeping the 512 character limit. Add cases to src/lib/auth/redirect.test.ts with and without a fragment, then run npx vitest run src/lib/auth/redirect.test.ts plus lint and typecheck; done means a signed-out visit to /w/<slug>/alerts/settings#alert-emails lands on the heading after sign-in.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area: auth bug impact: low priority: P3 size: S

Context

A signed-out reader who opens an app link with a fragment loses the fragment in sign-in, so they land on the right page but not on the section the link named.

Path, read from the code (raised in review of #354, thread https://github.com/eddiejaoude/DevMacro/pull/354#discussion_r4548573349):

  1. The browser asks for /w/<slug>/alerts/settings#alert-emails (the link in every alert email after #343), or /w/<slug>/alerts#alert-emails (every alert email sent before it). The fragment never reaches the server.
  2. src/proxy.ts:199-202 sees no session and redirects to /sign-in?next=..., building next from pathname and search only.
  3. The browser carries #alert-emails onto /sign-in, but the sign-in form posts the Server Function signInWithGitHub (src/app/sign-in/page.tsx:58-87) with the next bound on the server (page.tsx:108), which starts a new navigation to GitHub. The fragment is gone from here on.
  4. /auth/callback redirects to next, so the reader lands on the page with no fragment.

For the old /alerts#alert-emails links this means the reader stays on the inbox, because MovedSettingsRedirect (#343) only forwards a settings fragment it can see. For the new links it means alert settings opens at the top instead of at Alert emails. That is the path for any alert email opened on a phone or in a browser with no session.

safeNextPath already keeps a fragment (src/lib/auth/redirect.ts:58, covered by redirect.test.ts:11), and /auth/callback and /auth/confirm pass next through it, so only the step that builds next in the browser is missing.

Plan

  1. In src/app/sign-in/sign-in-form.tsx, read window.location.hash in the browser and send it with the form (for example a hidden field the Server Function reads), so signInWithGitHub builds next as the bound path plus the fragment.
  2. Pass the combined value through safeNextPath on the server as today, so a fragment cannot widen what next may target, and keep the 512 character limit.
  3. Leave src/proxy.ts as it is: a fragment cannot be read there.

Acceptance criteria

  • Signed out, opening /w/<slug>/alerts/settings#alert-emails and signing in ends on alert settings with the Alert emails heading in view and focused.
  • Signed out, opening /w/<slug>/alerts#alert-emails and signing in ends on alert settings at Alert emails (the #343 forward runs after sign-in).
  • A link with no fragment signs in to the same page as today, and a next with a fragment still falls back to /app when the path is not an app path.
  • Unit tests for building next with and without a fragment, including the length limit.
  • Playwright e2e coverage for the signed-out round trip, or a note saying why the GitHub step cannot be driven in e2e and what covers it instead.

Files and areas

  • src/app/sign-in/sign-in-form.tsx, src/app/sign-in/page.tsx, src/lib/auth/redirect.ts and its tests, an e2e spec under e2e/.
  • Non-goals: changing the proxy redirect, the OAuth provider, or what safeNextPath accepts.

Verification

npx vitest run src/lib/auth/redirect.test.ts, the sign-in e2e spec through the guarded runner, npm run lint, npm run typecheck.

Branch: <issue-number>-sign-in-keeps-fragment
Closes with a Closes #<issue-number> footer on the commit or pull request.

Model: anthropic/claude-opus-5-5 | Reasoning effort: medium

Lingua principale
TypeScript
Stelle
1
Fork
1
Merge medio
6h 56m
PR unite (30g)
136

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di eddiejaoude/StackDash

Tutte le issue di eddiejaoude/StackDash

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.