fix(auth): keep a link's fragment through sign-in

Abierto
  • ¿Algo no está bien?
#358 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
72/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
nextjs, react, typescript
Área
authentication, frontend

Línea de trabajo

Start by reading src/lib/auth/redirect.ts around line 58 to see how safeNextPath already carries a fragment, then src/app/sign-in/page.tsx:58-108 to see how next is bound to the signInWithGitHub Server Function. The missing piece is in src/app/sign-in/sign-in-form.tsx: read window.location.hash and pass it with the form so the server composes path plus fragment before safeNextPath, keeping the 512 character limit. Add cases to src/lib/auth/redirect.test.ts with and without a fragment, then run npx vitest run src/lib/auth/redirect.test.ts plus lint and typecheck; done means a signed-out visit to /w/<slug>/alerts/settings#alert-emails lands on the heading after sign-in.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area: auth bug impact: low priority: P3 size: S

Context

A signed-out reader who opens an app link with a fragment loses the fragment in sign-in, so they land on the right page but not on the section the link named.

Path, read from the code (raised in review of #354, thread https://github.com/eddiejaoude/DevMacro/pull/354#discussion_r4548573349):

  1. The browser asks for /w/<slug>/alerts/settings#alert-emails (the link in every alert email after #343), or /w/<slug>/alerts#alert-emails (every alert email sent before it). The fragment never reaches the server.
  2. src/proxy.ts:199-202 sees no session and redirects to /sign-in?next=..., building next from pathname and search only.
  3. The browser carries #alert-emails onto /sign-in, but the sign-in form posts the Server Function signInWithGitHub (src/app/sign-in/page.tsx:58-87) with the next bound on the server (page.tsx:108), which starts a new navigation to GitHub. The fragment is gone from here on.
  4. /auth/callback redirects to next, so the reader lands on the page with no fragment.

For the old /alerts#alert-emails links this means the reader stays on the inbox, because MovedSettingsRedirect (#343) only forwards a settings fragment it can see. For the new links it means alert settings opens at the top instead of at Alert emails. That is the path for any alert email opened on a phone or in a browser with no session.

safeNextPath already keeps a fragment (src/lib/auth/redirect.ts:58, covered by redirect.test.ts:11), and /auth/callback and /auth/confirm pass next through it, so only the step that builds next in the browser is missing.

Plan

  1. In src/app/sign-in/sign-in-form.tsx, read window.location.hash in the browser and send it with the form (for example a hidden field the Server Function reads), so signInWithGitHub builds next as the bound path plus the fragment.
  2. Pass the combined value through safeNextPath on the server as today, so a fragment cannot widen what next may target, and keep the 512 character limit.
  3. Leave src/proxy.ts as it is: a fragment cannot be read there.

Acceptance criteria

  • Signed out, opening /w/<slug>/alerts/settings#alert-emails and signing in ends on alert settings with the Alert emails heading in view and focused.
  • Signed out, opening /w/<slug>/alerts#alert-emails and signing in ends on alert settings at Alert emails (the #343 forward runs after sign-in).
  • A link with no fragment signs in to the same page as today, and a next with a fragment still falls back to /app when the path is not an app path.
  • Unit tests for building next with and without a fragment, including the length limit.
  • Playwright e2e coverage for the signed-out round trip, or a note saying why the GitHub step cannot be driven in e2e and what covers it instead.

Files and areas

  • src/app/sign-in/sign-in-form.tsx, src/app/sign-in/page.tsx, src/lib/auth/redirect.ts and its tests, an e2e spec under e2e/.
  • Non-goals: changing the proxy redirect, the OAuth provider, or what safeNextPath accepts.

Verification

npx vitest run src/lib/auth/redirect.test.ts, the sign-in e2e spec through the guarded runner, npm run lint, npm run typecheck.

Branch: <issue-number>-sign-in-keeps-fragment
Closes with a Closes #<issue-number> footer on the commit or pull request.

Model: anthropic/claude-opus-5-5 | Reasoning effort: medium

Lenguaje dominante
TypeScript
Estrellas
1
Forks
1
Merge medio
6 h 56 min
PR fusionados (30 d)
136

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de eddiejaoude/StackDash

Todos los issues de eddiejaoude/StackDash

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.