Alerts pagers reset the other lists' page and acknowledged filter

Aperta
  • Qualcosa non va?
#316 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
72/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
nextjs, react, typescript
Ambito
frontend

Direzione di ricerca

Start with hrefFor in src/components/alerts/triggered-alerts.tsx (around lines 143-149) and pageHref in src/components/alerts/alert-settings.tsx (around lines 220-229) at commit 527f880, and trace how each link is passed the current query state. Both helpers should spread the existing acknowledged, alertsAfter, rulesAfter and budgetsAfter params and override only their own cursor; the acknowledged toggle needs the same treatment. The existing e2e suite is the place to add one cross-list case, and you are done when that test shows a budget click preserving an older alerts page with acknowledged alerts on.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

area: alerts bug impact: low priority: P3 size: S

Summary

The alerts page has three independent pagers, and each one drops the other lists' place. "Show older alerts" builds its link with hrefFor (src/components/alerts/triggered-alerts.tsx, lines 143 to 149 at 527f880), which sets only acknowledged and alertsAfter. "Show more rules" and "Show more budgets" build theirs with pageHref (src/components/alerts/alert-settings.tsx, lines 220 to 229), which sets only rulesAfter and budgetsAfter.

So paging the budgets resets the triggered alerts list to its newest page and turns off "Show acknowledged alerts", and paging the triggered alerts resets the rules and budgets lists to their first pages.

Found by the Fable review of #315 (round 1). It is the same on the base of that pull request, so it is its own issue rather than part of #313.

Scope

  • Each pager link keeps every other list's query parameter (acknowledged, alertsAfter, rulesAfter, budgetsAfter) and changes only its own cursor.
  • The "Show acknowledged alerts" toggle keeps rulesAfter and budgetsAfter.

Acceptance criteria

  • With the triggered alerts on an older page and acknowledged alerts shown, "Show more budgets" keeps both.
  • With rules and budgets on a later page, "Show older alerts" keeps both.
  • An e2e test covers one cross-list case.

Model: anthropic/claude-opus-5-5 | Reasoning effort: low

Lingua principale
TypeScript
Stelle
1
Fork
1
Merge medio
6h 56m
PR unite (30g)
136

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di eddiejaoude/StackDash

Tutte le issue di eddiejaoude/StackDash

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.