Alerts pagers reset the other lists' page and acknowledged filter

Abierto
#316 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
72/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
nextjs, react, typescript
Área
frontend

Línea de trabajo

Start with hrefFor in src/components/alerts/triggered-alerts.tsx (around lines 143-149) and pageHref in src/components/alerts/alert-settings.tsx (around lines 220-229) at commit 527f880, and trace how each link is passed the current query state. Both helpers should spread the existing acknowledged, alertsAfter, rulesAfter and budgetsAfter params and override only their own cursor; the acknowledged toggle needs the same treatment. The existing e2e suite is the place to add one cross-list case, and you are done when that test shows a budget click preserving an older alerts page with acknowledged alerts on.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

area: alerts bug impact: low priority: P3 size: S

Summary

The alerts page has three independent pagers, and each one drops the other lists' place. "Show older alerts" builds its link with hrefFor (src/components/alerts/triggered-alerts.tsx, lines 143 to 149 at 527f880), which sets only acknowledged and alertsAfter. "Show more rules" and "Show more budgets" build theirs with pageHref (src/components/alerts/alert-settings.tsx, lines 220 to 229), which sets only rulesAfter and budgetsAfter.

So paging the budgets resets the triggered alerts list to its newest page and turns off "Show acknowledged alerts", and paging the triggered alerts resets the rules and budgets lists to their first pages.

Found by the Fable review of #315 (round 1). It is the same on the base of that pull request, so it is its own issue rather than part of #313.

Scope

  • Each pager link keeps every other list's query parameter (acknowledged, alertsAfter, rulesAfter, budgetsAfter) and changes only its own cursor.
  • The "Show acknowledged alerts" toggle keeps rulesAfter and budgetsAfter.

Acceptance criteria

  • With the triggered alerts on an older page and acknowledged alerts shown, "Show more budgets" keeps both.
  • With rules and budgets on a later page, "Show older alerts" keeps both.
  • An e2e test covers one cross-list case.

Model: anthropic/claude-opus-5-5 | Reasoning effort: low

Lenguaje dominante
TypeScript
Estrellas
1
Forks
1
Merge medio
6 h 32 min
PR fusionados (30 d)
156

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de eddiejaoude/StackDash

Todos los issues de eddiejaoude/StackDash

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.