Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Hidden star banner and back to top buttons are in the keyboard tab order on every page

Aperta Adatta ai principianti
  • Qualcosa non va?
#169 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
86/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
accessibility, frontend

Direzione di ricerca

Leggi gli stili nascosti e visibili in src/components/StarBanner.astro e src/components/BackToTop.astro, confrontandoli con il menu mobile chiuso in src/components/Header.astro. Controlla l’ordine di tabulazione da tastiera prima e dopo che ogni controllo diventa visibile o viene nascosto, e conferma che le dissolvenze continuano a funzionare. Il lavoro è completato quando i controlli nascosti non possono ricevere il focus, i controlli visibili del banner continuano a funzionare e i controlli di accettazione vengono superati.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

accessibility bug good first issue hacktoberfest

On any page of https://og.codercops.com, Tab past the last footer link ("CODERCOPS"). The next three stops are "Star on GitHub", "Maybe later" and "Close" in the star banner, which isn't on screen, so the focus seems to vanish. On a short page like /preview, the fourth stop is the Back to top button, which is also invisible until you've scrolled 500px. Only then does focus reach the Feedback button.

The banner stays in the tab order even after you've dismissed it for good. And while it's hidden it has aria-hidden="true", so screen reader users can land on controls inside a region that's supposed to be hidden.

Both hide with opacity: 0 and pointer-events: none, which doesn't take anything out of the tab order:

  • src/components/StarBanner.astro: aria-hidden="true" on line 2, the hidden style on lines 94 to 97, and the visible class on lines 100 to 104
  • src/components/BackToTop.astro: the hidden style on lines 48 to 51, and the visible class on lines 54 to 58

The mobile menu already gets this right: it uses visibility: hidden while it's closed (src/components/Header.astro, lines 277 to 291).

What to do

  • Make both unfocusable while they're hidden. The simplest way is CSS: add visibility: hidden to the hidden state and visibility: visible to the visible class, and add visibility to the transition so the fade out still plays. Toggling the inert attribute together with the class works too.
  • Keep the banner's aria-hidden matching what's on screen, as it does now.
  • The back to top script is also part of #161 (scripts that stop working after you follow a link inside the site), so a change that only touches CSS is the easiest to merge alongside it.

Where to look

  • src/components/StarBanner.astro: the markup (lines 2 to 20), hideBanner (lines 47 to 53), where it's shown (lines 57 to 62) and the styles (lines 83 to 104)
  • src/components/BackToTop.astro: toggle (lines 14 to 20) and the styles (lines 32 to 58)
  • src/components/Header.astro: the closed mobile menu (lines 277 to 291), for comparison

Acceptance criteria

  • While the banner is hidden (before it appears, after "Maybe later", or after dismissing it for good), Tab goes from the last footer link to the next control you can see
  • Back to top is in the tab order only while it's visible
  • When the banner is showing, its three controls can be reached with Tab and still work
  • The fade in and out look the same as before
  • npm run check, npm run test and npm run build pass
  • The PR says how you checked the tab order (with the keyboard, or the browser's accessibility tree)

Want to work on this? Comment below and I'll assign it to you. Please take one issue at a time, branch off dev, and open your PR against dev with Closes #169 in the description.

Lingua principale
TypeScript
Stelle
8
Fork
4
Merge medio
6h 9m
PR unite (30g)
66

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di codercops/ogcops

Tutte le issue di codercops/ogcops

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.