Hacktoberfest 2026 : les issues que les mainteneurs ont marquées pour octobre, ouvertes et accessibles aux débutants. Parcourir les issues Hacktoberfest

Hidden star banner and back to top buttons are in the keyboard tab order on every page

Fermée Adaptée aux débutants
  • Quelque chose ne va pas ?
#169 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
2/5
Temps estimé
1-3 heures
Accessibilité débutants
86/100
Type d'issue
Bug
Clarté
Clairement spécifiée
Activité
Active
Stack technique
typescript
Domaine
accessibility, frontend

Piste de recherche

Lisez les styles masqués et visibles dans src/components/StarBanner.astro et src/components/BackToTop.astro, puis comparez-les au menu mobile fermé dans src/components/Header.astro. Vérifiez l’ordre de tabulation au clavier avant et après que chaque contrôle devient visible ou est masqué, et confirmez que les fondus fonctionnent toujours. Le travail est terminé lorsque les contrôles masqués ne peuvent pas recevoir le focus, que les contrôles visibles de la bannière fonctionnent toujours et que les critères d’acceptation sont remplis.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

accessibility bug good first issue hacktoberfest

On any page of https://og.codercops.com, Tab past the last footer link ("CODERCOPS"). The next three stops are "Star on GitHub", "Maybe later" and "Close" in the star banner, which isn't on screen, so the focus seems to vanish. On a short page like /preview, the fourth stop is the Back to top button, which is also invisible until you've scrolled 500px. Only then does focus reach the Feedback button.

The banner stays in the tab order even after you've dismissed it for good. And while it's hidden it has aria-hidden="true", so screen reader users can land on controls inside a region that's supposed to be hidden.

Both hide with opacity: 0 and pointer-events: none, which doesn't take anything out of the tab order:

  • src/components/StarBanner.astro: aria-hidden="true" on line 2, the hidden style on lines 94 to 97, and the visible class on lines 100 to 104
  • src/components/BackToTop.astro: the hidden style on lines 48 to 51, and the visible class on lines 54 to 58

The mobile menu already gets this right: it uses visibility: hidden while it's closed (src/components/Header.astro, lines 277 to 291).

What to do

  • Make both unfocusable while they're hidden. The simplest way is CSS: add visibility: hidden to the hidden state and visibility: visible to the visible class, and add visibility to the transition so the fade out still plays. Toggling the inert attribute together with the class works too.
  • Keep the banner's aria-hidden matching what's on screen, as it does now.
  • The back to top script is also part of #161 (scripts that stop working after you follow a link inside the site), so a change that only touches CSS is the easiest to merge alongside it.

Where to look

  • src/components/StarBanner.astro: the markup (lines 2 to 20), hideBanner (lines 47 to 53), where it's shown (lines 57 to 62) and the styles (lines 83 to 104)
  • src/components/BackToTop.astro: toggle (lines 14 to 20) and the styles (lines 32 to 58)
  • src/components/Header.astro: the closed mobile menu (lines 277 to 291), for comparison

Acceptance criteria

  • While the banner is hidden (before it appears, after "Maybe later", or after dismissing it for good), Tab goes from the last footer link to the next control you can see
  • Back to top is in the tab order only while it's visible
  • When the banner is showing, its three controls can be reached with Tab and still work
  • The fade in and out look the same as before
  • npm run check, npm run test and npm run build pass
  • The PR says how you checked the tab order (with the keyboard, or the browser's accessibility tree)

Want to work on this? Comment below and I'll assign it to you. Please take one issue at a time, branch off dev, and open your PR against dev with Closes #169 in the description.

Langage dominant
TypeScript
Étoiles
8
Forks
4
Merge moyen
5 h 44 min
PR mergées (30 j)
83

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de codercops/ogcops

Toutes les issues de codercops/ogcops

Issues similaires

Plus d'issues TypeScript

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.