`/leaderboard`, the page and the share image say "be the first" for a program that hasn't started

Aperta Adatta ai principianti
  • Qualcosa non va?
#152 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
84/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
backend

Direzione di ricerca

Inizia in src/messages.ts a leaderboardMessage (riga 136) e nel testo della board vuota (righe 167-173): il messaggio richiede un flag avviato/non avviato passato nel modo in cui oggi viene passato final. src/page.ts costruisce già statusLine e src/card.ts costruisce boardState, quindi porta quello stato in entrambi, e in src/commands.ts (caso leaderboard, riga 80) salta la ricerca GitHub quando il programma non è stato avviato. Scrivi prima test che falliscono in test/messages.test.ts, test/card.test.ts e test/page.test.ts; fatto significa che tutte e tre le superfici riportano la data di inizio e che npm test e npm run typecheck passano.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug good first issue

Pick CODERCOPS December 2026 in /leaderboard and the reply says:

No merged PRs counted yet. Pick a starter issue and be the first.

But a PR merged now counts for November, not December. The program's page and its share image say the same thing, right under their own "Starts Dec 1, 2026" and "STARTS DEC 1" labels. oss.codercops.com/leaderboard/2026-12 shows it today. The text comes from three places:

  • src/messages.ts, line 172. leaderboardMessage only knows whether a program has ended (final), not whether it has started.
  • src/page.ts, line 245, the empty board on the page
  • src/card.ts, line 219, the board image at /leaderboard/2026-12.png

The /leaderboard reply also searches GitHub for a date range in the future (getLeaderboard in src/commands.ts, line 83). Nothing can match, and it uses up a request from GitHub's search limit (30 a minute with a token).

What to do

  • For a program that hasn't started, say when it starts instead, for example "Starts Dec 1, 2026 (UTC). PRs merged before then don't count for it." in all three places. The page and the card already know the status (statusLine in src/page.ts, line 23, and boardState in src/card.ts, line 130). leaderboardMessage needs it passed in, the way final is today.
  • In the leaderboard command, don't search GitHub for a program that hasn't started. An empty board is enough.

Where to look

  • src/messages.ts: leaderboardMessage (line 136) and the empty board text (lines 167 to 173)
  • src/page.ts: statusLine (line 23) and line 245
  • src/card.ts: boardState (line 130) and lines 217 to 219
  • src/commands.ts: the leaderboard case (line 80)
  • test/messages.test.ts: the empty board tests (lines 277 and 286); test/card.test.ts: the empty state test (line 160); test/page.test.ts: statusLine (line 51)

Acceptance criteria

  • For a program that hasn't started, the reply, the page and the image say when it starts and don't say "be the first"
  • Running and ended programs read the same as now
  • /leaderboard for a program that hasn't started makes no GitHub search request
  • Tests that fail on the current code
  • npm run typecheck and npm test pass

How to test

The tests already have an upcoming program to copy (test/card.test.ts, line 372, uses one starting in 2100). For the command, run runCommand with the program option set to an upcoming one and check with mockFetch that no /search/issues call was made. By hand: npm run dev, then open http://localhost:8787/leaderboard/2026-12 and http://localhost:8787/leaderboard/2026-12.png. Both work without any secrets.

Want to work on this? Comment below and I'll assign it to you. Please take one issue at a time, branch off develop, and open your PR against develop with Closes #152 in the description.

Lingua principale
TypeScript
Stelle
0
Fork
1
Merge medio
2h 38m
PR unite (30g)
73

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di codercops/discord-bot

Tutte le issue di codercops/discord-bot

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.