`/leaderboard`, the page and the share image say "be the first" for a program that hasn't started

Abierto Apto para principiantes
  • ¿Algo no está bien?
#152 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
84/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
typescript
Área
backend

Línea de trabajo

Empieza en src/messages.ts en leaderboardMessage (línea 136) y el texto de tablero vacío (líneas 167-173): el mensaje necesita un flag de iniciado/no iniciado pasado de la forma en que hoy se pasa final. src/page.ts ya construye statusLine y src/card.ts construye boardState, así que propaga ese estado a ambos, y en src/commands.ts (caso leaderboard, línea 80) omite la búsqueda de GitHub cuando el programa no ha empezado. Escribe primero tests que fallen en test/messages.test.ts, test/card.test.ts y test/page.test.ts; terminado es que las tres superficies digan la fecha de inicio y que npm test y npm run typecheck pasen.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

bug good first issue

Pick CODERCOPS December 2026 in /leaderboard and the reply says:

No merged PRs counted yet. Pick a starter issue and be the first.

But a PR merged now counts for November, not December. The program's page and its share image say the same thing, right under their own "Starts Dec 1, 2026" and "STARTS DEC 1" labels. oss.codercops.com/leaderboard/2026-12 shows it today. The text comes from three places:

  • src/messages.ts, line 172. leaderboardMessage only knows whether a program has ended (final), not whether it has started.
  • src/page.ts, line 245, the empty board on the page
  • src/card.ts, line 219, the board image at /leaderboard/2026-12.png

The /leaderboard reply also searches GitHub for a date range in the future (getLeaderboard in src/commands.ts, line 83). Nothing can match, and it uses up a request from GitHub's search limit (30 a minute with a token).

What to do

  • For a program that hasn't started, say when it starts instead, for example "Starts Dec 1, 2026 (UTC). PRs merged before then don't count for it." in all three places. The page and the card already know the status (statusLine in src/page.ts, line 23, and boardState in src/card.ts, line 130). leaderboardMessage needs it passed in, the way final is today.
  • In the leaderboard command, don't search GitHub for a program that hasn't started. An empty board is enough.

Where to look

  • src/messages.ts: leaderboardMessage (line 136) and the empty board text (lines 167 to 173)
  • src/page.ts: statusLine (line 23) and line 245
  • src/card.ts: boardState (line 130) and lines 217 to 219
  • src/commands.ts: the leaderboard case (line 80)
  • test/messages.test.ts: the empty board tests (lines 277 and 286); test/card.test.ts: the empty state test (line 160); test/page.test.ts: statusLine (line 51)

Acceptance criteria

  • For a program that hasn't started, the reply, the page and the image say when it starts and don't say "be the first"
  • Running and ended programs read the same as now
  • /leaderboard for a program that hasn't started makes no GitHub search request
  • Tests that fail on the current code
  • npm run typecheck and npm test pass

How to test

The tests already have an upcoming program to copy (test/card.test.ts, line 372, uses one starting in 2100). For the command, run runCommand with the program option set to an upcoming one and check with mockFetch that no /search/issues call was made. By hand: npm run dev, then open http://localhost:8787/leaderboard/2026-12 and http://localhost:8787/leaderboard/2026-12.png. Both work without any secrets.

Want to work on this? Comment below and I'll assign it to you. Please take one issue at a time, branch off develop, and open your PR against develop with Closes #152 in the description.

Lenguaje dominante
TypeScript
Estrellas
0
Forks
1
Merge medio
2 h 38 min
PR fusionados (30 d)
73

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de codercops/discord-bot

Todos los issues de codercops/discord-bot

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.