CoderWorkspacePool: use after the last read can still be bound or deleted on a delete retry

Chiusa
  • Qualcosa non va?
#409 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
28/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
go, kubernetes
Ambito
backend

Direzione di ricerca

Read the two threads on PR #404 first, then bindClaims in internal/controller/coderworkspacepool_claim.go and cleanupStep in internal/controller/coderworkspacepoolmember_cleanup.go to see where each check sits relative to the delete/bind boundary. Before writing anything, answer the open question in the issue: does Coder move last_used_at on a failed delete build? A failed-delete test against the member cleanup path is the place to establish that. Done means both paths re-check use at the boundary, existing reconciler tests still pass, and the residual flush-delay window is documented.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Problem

Two paths can still hand out or delete a pool workspace that someone used after the member's last read of Coder. Codex found both on #404. Both exist on main and are outside #349, which #404 fixes.

  1. Bind uses stored status. bindClaims (internal/controller/coderworkspacepool_claim.go) picks members by their stored Ready and Used conditions. A member reads last_used_at once a minute. Use after that read and before the next one is not in status yet, so a new claim can bind the workspace. The resourceVersion precondition cannot see a change in Coder. Thread: https://github.com/coder/coder-k8s/pull/404#discussion_r4424757093
  2. No use check before a delete retry. cleanupStep (internal/controller/coderworkspacepoolmember_cleanup.go) runs the last use check only before the first delete build (DeleteBuildID == "" && DeleteAttempts == 0). If that build fails or is canceled and someone uses the workspace during the retry backoff, the retry deletes it. Thread: https://github.com/coder/coder-k8s/pull/404#discussion_r4424757101

Neither path can close the gap fully. Coder records use up to one usage flush (about 60 s) late, and it has no conditional delete or bind. The fixes narrow the window to that flush delay.

Possible fix

  1. Read the workspace from Coder at the bind boundary and skip a member whose last_used_at is past its readyLastUsedAt.
  2. Run the last use check before every new delete build, not only the first. Check first whether Coder moves last_used_at on a failed delete build. If it does, every failed delete would release its member (a leak, the fail-safe side).

Trigger

Before #153 PR 12 registers the pool reconcilers.

Owner: maintainer desk.

Refs #153
Refs #404

Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: xhigh

Lingua principale
Go
Stelle
5
Fork
3
Merge medio
2h 49m
PR unite (30g)
206

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di coder/coder-k8s

Tutte le issue di coder/coder-k8s

Issue simili

Altre issue su Go

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.