CoderWorkspacePool: use after the last read can still be bound or deleted on a delete retry

Fermée
  • Quelque chose ne va pas ?
#409 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub

Les mainteneurs répondent en général sous 1 jour

Personne n'a encore pris cette issue.

Évaluation

Difficulté
4/5
Temps estimé
3-5 jours
Accessibilité débutants
28/100
Type d'issue
Bug
Clarté
Plutôt claire
Activité
Active
Stack technique
go, kubernetes
Domaine
backend

Piste de recherche

Read the two threads on PR #404 first, then bindClaims in internal/controller/coderworkspacepool_claim.go and cleanupStep in internal/controller/coderworkspacepoolmember_cleanup.go to see where each check sits relative to the delete/bind boundary. Before writing anything, answer the open question in the issue: does Coder move last_used_at on a failed delete build? A failed-delete test against the member cleanup path is the place to establish that. Done means both paths re-check use at the boundary, existing reconciler tests still pass, and the residual flush-delay window is documented.

Rédigé par le modèle d'indexation à partir du texte de l'issue.

Description

Problem

Two paths can still hand out or delete a pool workspace that someone used after the member's last read of Coder. Codex found both on #404. Both exist on main and are outside #349, which #404 fixes.

  1. Bind uses stored status. bindClaims (internal/controller/coderworkspacepool_claim.go) picks members by their stored Ready and Used conditions. A member reads last_used_at once a minute. Use after that read and before the next one is not in status yet, so a new claim can bind the workspace. The resourceVersion precondition cannot see a change in Coder. Thread: https://github.com/coder/coder-k8s/pull/404#discussion_r4424757093
  2. No use check before a delete retry. cleanupStep (internal/controller/coderworkspacepoolmember_cleanup.go) runs the last use check only before the first delete build (DeleteBuildID == "" && DeleteAttempts == 0). If that build fails or is canceled and someone uses the workspace during the retry backoff, the retry deletes it. Thread: https://github.com/coder/coder-k8s/pull/404#discussion_r4424757101

Neither path can close the gap fully. Coder records use up to one usage flush (about 60 s) late, and it has no conditional delete or bind. The fixes narrow the window to that flush delay.

Possible fix

  1. Read the workspace from Coder at the bind boundary and skip a member whose last_used_at is past its readyLastUsedAt.
  2. Run the last use check before every new delete build, not only the first. Check first whether Coder moves last_used_at on a failed delete build. If it does, every failed delete would release its member (a leak, the fail-safe side).

Trigger

Before #153 PR 12 registers the pool reconcilers.

Owner: maintainer desk.

Refs #153
Refs #404

Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: xhigh

Langage dominant
Go
Étoiles
5
Forks
3
Merge moyen
2 h 49 min
PR mergées (30 j)
206

Préparer son environnement

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Autres issues de coder/coder-k8s

Toutes les issues de coder/coder-k8s

Issues similaires

Plus d'issues Go

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.