🤖 fix: handle template imports that outlast the request deadline
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 45/100
Direzione di ricerca
The issue relates to the synchronous template import flow in the aggregated API server. Start by examining the code for creating a CoderTemplate (likely in a controller or handler) and the import logic from #116. Understand how the CODER_K8S_TEMPLATE_VERSION_BUILD_WAIT_TIMEOUT environment variable and kube-apiserver's --request-timeout interact. Look for where file uploads and template versions are managed to assess idempotency or async status reporting. Testing will require setting up a slow import scenario to verify timeout behavior.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Problem
After #116, creating a CoderTemplate with spec.files returns only after Coder finishes importing the template. The server-side limit is CODER_K8S_TEMPLATE_VERSION_BUILD_WAIT_TIMEOUT (default 25 minutes), capped by the request deadline. Requests reach the aggregated API server through kube-apiserver, whose default --request-timeout is 60 seconds, and clients can set shorter deadlines.
If an import takes longer than the effective deadline:
- the client receives a timeout;
- the server creates no template, so nothing half-created is exposed;
- the uploaded file and template version remain in Coder;
- a retry uploads and imports again and can leave additional versions.
The maintained E2E imports a trivial template in seconds, so this path has not been exercised on a real backend. It has not been verified whether kube-apiserver's timeout applies to proxied aggregated requests in every configuration.
Options to evaluate
- Keep the synchronous Create and document the limit (current state; documented in the aggregated API server how-to).
- Return early for slow imports and expose import progress through status or conditions, so clients can wait instead of retrying.
- Make retries idempotent for identical source (for example, reuse a pending or succeeded version with the same content hash).
Trigger and owner
Owner: maintainer desk. Revisit when a user reports a slow-import timeout, when a supported quickstart path is restored, or before advertising large templates as supported.
Follow-up from #105 and #116.
Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: xhigh
- Lingua principale
- Go
- Stelle
- 4
- Fork
- 3
- Merge medio
- 3h 48m
- PR unite (30g)
- 26
Preparare l'ambiente
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di coder/coder-k8s
-
Difficoltà 4/5 3-5 giorni Idoneità per principianti 52/100
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di coder/coder-k8s
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
I maintainer di solito rispondono entro 1 giorno
-
Remove obsolete ipAllocationPolicy field from containernodepool-subnetworkref test dependencyAperta
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 92/100
GoogleCloudPlatform/k8s-config-connector#13462 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
coder/coder#29955 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
microsoft/TypeScript#64453 ·
I maintainer di solito rispondono entro 1 giorno
-
OpenAI-compatible endpoint: response ids have only 999 possible values (chatcmpl-rand.Intn(999))Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
I maintainer di solito rispondono entro 1 giorno