🤖 fix: handle template imports that outlast the request deadline
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 45/100
Línea de trabajo
The issue relates to the synchronous template import flow in the aggregated API server. Start by examining the code for creating a CoderTemplate (likely in a controller or handler) and the import logic from #116. Understand how the CODER_K8S_TEMPLATE_VERSION_BUILD_WAIT_TIMEOUT environment variable and kube-apiserver's --request-timeout interact. Look for where file uploads and template versions are managed to assess idempotency or async status reporting. Testing will require setting up a slow import scenario to verify timeout behavior.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Problem
After #116, creating a CoderTemplate with spec.files returns only after Coder finishes importing the template. The server-side limit is CODER_K8S_TEMPLATE_VERSION_BUILD_WAIT_TIMEOUT (default 25 minutes), capped by the request deadline. Requests reach the aggregated API server through kube-apiserver, whose default --request-timeout is 60 seconds, and clients can set shorter deadlines.
If an import takes longer than the effective deadline:
- the client receives a timeout;
- the server creates no template, so nothing half-created is exposed;
- the uploaded file and template version remain in Coder;
- a retry uploads and imports again and can leave additional versions.
The maintained E2E imports a trivial template in seconds, so this path has not been exercised on a real backend. It has not been verified whether kube-apiserver's timeout applies to proxied aggregated requests in every configuration.
Options to evaluate
- Keep the synchronous Create and document the limit (current state; documented in the aggregated API server how-to).
- Return early for slow imports and expose import progress through status or conditions, so clients can wait instead of retrying.
- Make retries idempotent for identical source (for example, reuse a pending or succeeded version with the same content hash).
Trigger and owner
Owner: maintainer desk. Revisit when a user reports a slow-import timeout, when a supported quickstart path is restored, or before advertising large templates as supported.
Follow-up from #105 and #116.
Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: xhigh
- Lenguaje dominante
- Go
- Estrellas
- 4
- Forks
- 3
- Merge medio
- 5 h 26 min
- PR fusionados (30 d)
- 17
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de coder/coder-k8s
Todos los issues de coder/coder-k8s
Issues similares
-
agentic-workflows
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
-
agentic-workflows
Dificultad 2/5 1-3 horas Aptitud para principiantes 70/100
microsoft/agent-framework-go#1179 ·
-
bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
-
[Bug]: OLLAMA_KEEP_ALIVE="5m" / "24h" crashes Ollama embedding and vision models with ValueError Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
infiniflow/ragflow#20223 · 1 reacción ·
-
bug needs triage pkg/translator/faro
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
open-telemetry/opentelemetry-collector-contrib#51484 · 1 comentario ·