Modals stay modal (page inert, scrim live) for the whole exit animation: the first click after an outside dismissal is lost
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 55/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- typescript
- Ambito
- accessibility, frontend, testing
Direzione di ricerca
Start with components/Dialog/Dialog.svelte, primitives/presence.svelte.js, and primitives/layer.js to trace how closing state, animation completion, modal behavior, focus, and scroll locking interact. Reproduce the lost click using the provided Playwright timing steps, then inspect the ModalContract browser test mentioned in the issue. Done means a click shortly after dismissal reaches the page button and a nonterminating descendant animation cannot keep the dialog modal; the issue does not name exact test paths.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
What happens
A modal (Dialog, AlertDialog, Drawer, Sheet, CommandPalette) is closed by pressing outside it (or Escape, or a button). The user then clicks a button on the page behind it right away: the click does nothing, a second click is needed. The cursor looks stuck.
Measured on WebKit (Playwright 1.65 WebKit, headless, real mouse events; @codeatlasdev/ui 4.6.0), a click on a page button N ms after the dismissal:
| ms after dismissal | button handler runs |
|---|---|
| 30, 80 | no (press lost) |
| 150, 250, 400 | yes |
The same on Chromium (30 ms: lost). It is the whole 150 ms exit animation (--ca-enter-fast).
Root cause (installed 4.6.0, dist/)
Closing only flips data-state="closed"; the layer stays alive, still modal, until the exit animation finishes:
components/Dialog/Dialog.svelte:109,118createPresence(() => open)/{#if presence.present}: the<dialog>stays rendered whileexiting.primitives/presence.svelte.js:16-46(exiting = true, rAF, thenPromise.allSettled(anims.map(a => a.finished))at line 40):exitingonly clears when every running animation, in the whole subtree, has finished.primitives/layer.js:435-436dialog.showModal()and:460-466dialog.close()run only in the layer'sclose(), which the owner calls when the{#if}branch is destroyed, i.e. after the exit. Until then the dialog is a modal: the rest of the page is inert (HTML "blocked by a modal dialog") and::backdrop(dialog.css:51) still takes the pointer. A press on the page goes to the closing dialog:layer.js:451-456onClickcallsonDismissagain (a no-op) and the click never reaches the button.layer.js:25-35: a closing entry is skipped bytopInteractive/topModal, so the kit already treats the layer as "closing"; only the platform state (modal, inert, focus traplayer.js:434, scroll lock:432) is not released.
Side effect of the same line: an animation that never ends inside the dialog (a spinner with animation-iteration-count: infinite) makes Promise.allSettled wait forever, so the dialog never leaves (and stays modal).
Minimal reproduction
<script>
import { Dialog, Button } from "@codeatlasdev/ui";
let open = $state(false), n = $state(0);
</script>
<Button onclick={() => (open = true)}>Open</Button>
<Button id="other" onclick={() => n++}>Other {n}</Button>
<Dialog bind:open title="Dialog">hello</Dialog>
Open the dialog, press the scrim, and press #other within 150 ms (Playwright: page.mouse.click(scrim), page.waitForTimeout(30), page.mouse.click(other)): n stays 0.
Expected
A layer that has started closing must not intercept input: the page answers the first click after a dismissal, at any time.
Proposed fix
When a modal layer starts closing (closing() turns true in modalLayer), release the platform side at once and keep only the visual exit: release the focus trap and the scroll lock, dialog.close() then dialog.show() (non-modal, no ::backdrop, no inert page; re-focus the previously focused element after show() because it moves focus into the dialog) and draw the scrim fade with the dialog's own box-shadow spread, or fade a non-interactive sibling. pointer-events: none on [data-state="closed"] for the panel. Independently: in presence.svelte.js ignore animations whose effect.getComputedTiming().endTime is Infinity.
Also add a browser test (ModalContract-style): dismiss by scrim, click a page button 0/30/80 ms later, expect one handler call each.
Workaround in Atlas
codeatlasdev/atlas#501: one document-level observer finishes the exit animation of any closing dialog.ca-overlay (the kit then drops the layer the next frame), plus .ca-floating[data-state="closed"] { pointer-events: none }. Documented with the removal condition in docs/desktop.md ("UI kit workarounds"). Atlas will delete it when a kit release passes its regression test without it.
- Lingua principale
- TypeScript
- Stelle
- 6
- Fork
- 3
- Merge medio
- 5h 21m
- PR unite (30g)
- 378
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di codeatlasdev/ui
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 84/100
codeatlasdev/ui#1340 ·
I maintainer di solito rispondono entro 1 giorno
-
area:a11y area:components bug
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
codeatlasdev/ui#1336 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 77/100
codeatlasdev/ui#1329 ·
I maintainer di solito rispondono entro 1 giorno
-
good first issue
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
codeatlasdev/ui#1292 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
area:components enhancement good first issue
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
codeatlasdev/ui#1198 ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di codeatlasdev/ui
Issue simili
-
Console writes URL credentials to the local log, though AGENTS.md says secrets never reach diskAperta
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 86/100
sandbox-quantum/switch#2163 ·
I maintainer di solito rispondono entro 1 giorno
-
automated issue report
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 78/100
I maintainer di solito rispondono entro 1 giorno
-
area/dashboard kind/bug QA/dev-automation
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 75/100
I maintainer di solito rispondono entro 1 giorno
-
bug pydanty:is-working
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
pydantic/pydantic-ai#13939 ·
I maintainer di solito rispondono entro 1 giorno
-
self-host
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
funmusicplace/mirlo#2625 ·
I maintainer di solito rispondono entro 1 giorno