Modals stay modal (page inert, scrim live) for the whole exit animation: the first click after an outside dismissal is lost
Les mainteneurs répondent en général sous 1 jour
Personne n'a encore pris cette issue.
Évaluation
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Accessibilité débutants
- 55/100
- Type d'issue
- Bug
- Clarté
- Clairement spécifiée
- Activité
- Active
- Stack technique
- typescript
- Domaine
- accessibility, frontend, testing
Piste de recherche
Start with components/Dialog/Dialog.svelte, primitives/presence.svelte.js, and primitives/layer.js to trace how closing state, animation completion, modal behavior, focus, and scroll locking interact. Reproduce the lost click using the provided Playwright timing steps, then inspect the ModalContract browser test mentioned in the issue. Done means a click shortly after dismissal reaches the page button and a nonterminating descendant animation cannot keep the dialog modal; the issue does not name exact test paths.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Description
What happens
A modal (Dialog, AlertDialog, Drawer, Sheet, CommandPalette) is closed by pressing outside it (or Escape, or a button). The user then clicks a button on the page behind it right away: the click does nothing, a second click is needed. The cursor looks stuck.
Measured on WebKit (Playwright 1.65 WebKit, headless, real mouse events; @codeatlasdev/ui 4.6.0), a click on a page button N ms after the dismissal:
| ms after dismissal | button handler runs |
|---|---|
| 30, 80 | no (press lost) |
| 150, 250, 400 | yes |
The same on Chromium (30 ms: lost). It is the whole 150 ms exit animation (--ca-enter-fast).
Root cause (installed 4.6.0, dist/)
Closing only flips data-state="closed"; the layer stays alive, still modal, until the exit animation finishes:
components/Dialog/Dialog.svelte:109,118createPresence(() => open)/{#if presence.present}: the<dialog>stays rendered whileexiting.primitives/presence.svelte.js:16-46(exiting = true, rAF, thenPromise.allSettled(anims.map(a => a.finished))at line 40):exitingonly clears when every running animation, in the whole subtree, has finished.primitives/layer.js:435-436dialog.showModal()and:460-466dialog.close()run only in the layer'sclose(), which the owner calls when the{#if}branch is destroyed, i.e. after the exit. Until then the dialog is a modal: the rest of the page is inert (HTML "blocked by a modal dialog") and::backdrop(dialog.css:51) still takes the pointer. A press on the page goes to the closing dialog:layer.js:451-456onClickcallsonDismissagain (a no-op) and the click never reaches the button.layer.js:25-35: a closing entry is skipped bytopInteractive/topModal, so the kit already treats the layer as "closing"; only the platform state (modal, inert, focus traplayer.js:434, scroll lock:432) is not released.
Side effect of the same line: an animation that never ends inside the dialog (a spinner with animation-iteration-count: infinite) makes Promise.allSettled wait forever, so the dialog never leaves (and stays modal).
Minimal reproduction
<script>
import { Dialog, Button } from "@codeatlasdev/ui";
let open = $state(false), n = $state(0);
</script>
<Button onclick={() => (open = true)}>Open</Button>
<Button id="other" onclick={() => n++}>Other {n}</Button>
<Dialog bind:open title="Dialog">hello</Dialog>
Open the dialog, press the scrim, and press #other within 150 ms (Playwright: page.mouse.click(scrim), page.waitForTimeout(30), page.mouse.click(other)): n stays 0.
Expected
A layer that has started closing must not intercept input: the page answers the first click after a dismissal, at any time.
Proposed fix
When a modal layer starts closing (closing() turns true in modalLayer), release the platform side at once and keep only the visual exit: release the focus trap and the scroll lock, dialog.close() then dialog.show() (non-modal, no ::backdrop, no inert page; re-focus the previously focused element after show() because it moves focus into the dialog) and draw the scrim fade with the dialog's own box-shadow spread, or fade a non-interactive sibling. pointer-events: none on [data-state="closed"] for the panel. Independently: in presence.svelte.js ignore animations whose effect.getComputedTiming().endTime is Infinity.
Also add a browser test (ModalContract-style): dismiss by scrim, click a page button 0/30/80 ms later, expect one handler call each.
Workaround in Atlas
codeatlasdev/atlas#501: one document-level observer finishes the exit animation of any closing dialog.ca-overlay (the kit then drops the layer the next frame), plus .ca-floating[data-state="closed"] { pointer-events: none }. Documented with the removal condition in docs/desktop.md ("UI kit workarounds"). Atlas will delete it when a kit release passes its regression test without it.
- Langage dominant
- TypeScript
- Étoiles
- 6
- Forks
- 3
- Merge moyen
- 5 h 21 min
- PR mergées (30 j)
- 378
Préparer son environnement
- Aucun Dockerfile ni fichier Docker Compose
- Propose un modèle de pull request
- Lire le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Autres issues de codeatlasdev/ui
-
Difficulté 2/5 1-3 heures Accessibilité débutants 84/100
codeatlasdev/ui#1340 ·
Les mainteneurs répondent en général sous 1 jour
-
area:a11y area:components bug
Difficulté 2/5 1-3 heures Accessibilité débutants 76/100
codeatlasdev/ui#1336 ·
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 2/5 1-3 heures Accessibilité débutants 77/100
codeatlasdev/ui#1329 ·
Les mainteneurs répondent en général sous 1 jour
-
good first issue
Difficulté 2/5 1-3 heures Accessibilité débutants 74/100
codeatlasdev/ui#1292 · 1 commentaire ·
Les mainteneurs répondent en général sous 1 jour
-
area:components enhancement good first issue
Difficulté 2/5 1-3 heures Accessibilité débutants 68/100
codeatlasdev/ui#1198 ·
Les mainteneurs répondent en général sous 1 jour
Toutes les issues de codeatlasdev/ui
Issues similaires
-
bug frontend
Difficulté 2/5 1-3 heures Accessibilité débutants 85/100
CivicTechWR/accessible-housing-portal#578 ·
Les mainteneurs répondent en général sous 1 jour
-
Difficulté 2/5 1-3 heures Accessibilité débutants 68/100
nekko-labs/nekko-agent#2998 ·
Les mainteneurs répondent en général sous 1 jour
-
Console writes URL credentials to the local log, though AGENTS.md says secrets never reach diskOuverte
Difficulté 1/5 Moins d'une heure Accessibilité débutants 86/100
sandbox-quantum/switch#2163 ·
Les mainteneurs répondent en général sous 1 jour
-
enhancement ux
Difficulté 2/5 1-3 heures Accessibilité débutants 72/100
lolimmlost/aidj#433 ·
Les mainteneurs répondent en général sous 1 jour
-
test: ipcShownDialogKeys.test.tsx can fail the unit run with 'window is not defined' after it endsOuverte
Difficulté 2/5 1-3 heures Accessibilité débutants 72/100
Les mainteneurs répondent en général sous 1 jour