DTL export: map sub-brands to the parent manufacturer used by the Device Type Library

Aperta
  • Qualcosa non va?
#429 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
53/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
javascript
Ambito
data

Direzione di ricerca

Find the DTL export and generation entry point, then trace how camera brands become manufacturer folders, filenames, and slugs. Use the Meraki example and the linked DTL pull request to check the expected manufacturer and model prefix mapping. Done means brands that belong under an existing manufacturer export there while preserving the slug and slugified model filename; separate DTL brands remain unchanged.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Context

While contributing Meraki cameras to the NetBox Device Type Library (netbox-community/devicetype-library#4765), a reviewer pointed out that the library already has 86 Meraki devices under device-types/Cisco/ (manufacturer: Cisco, model: Meraki MR36, slug: cisco-meraki-mr36). The PR had created a separate Cisco Meraki manufacturer, which would split one vendor into two NetBox manufacturers. It was fixed in the PR (files now live at device-types/Cisco/Meraki-MVxx.yaml).

TODO
  • Add a brand-to-manufacturer mapping to the DTL export/generation step: a cctv brand should map to the existing DTL manufacturer (and model prefix) when the library already has one, instead of creating a new folder named after the cctv brand.
  • Before generating a new brand, check whether its name starts with, or is a sub-brand of, an existing DTL manufacturer directory, and whether existing files elsewhere use the brand as a model prefix.
  • Keep the filename equal to the slugified model and the slug unchanged (e.g. Meraki-MV22.yaml, cisco-meraki-mv22).
Already checked (2026-11-08)

Other brands contributed so far were compared against the existing DTL manufacturer folders; no other case of the same problem was found. Brands that already have their own separate folders in the DTL (e.g. HiLook, VIGI, i-PRO, IMOU, Lorex) are unaffected.

Reference: https://github.com/netbox-community/devicetype-library/pull/4765

Lingua principale
JavaScript
Stelle
267
Fork
21
Merge medio
1g 3h
PR unite (30g)
8

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di ch-bas/cctv-camera-database

Tutte le issue di ch-bas/cctv-camera-database

Issue simili

Altre issue su JavaScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.