Comparison photo of Jupiter near moon

Aperta
#192 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
45/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
javascript, three.js

Direzione di ricerca

Start by reproducing the Jupiter-and-moon comparison using the linked Celestiary URL and the provided reference images. The issue lists several separate UI and rendering discrepancies, including Jupiter pixelation, missing stars, exposure, and lunar shading, but names no files or tests. First identify the rendering and UI entry points, then agree on one discrepancy to address; done means that specific difference is improved against the reference.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug

From: https://www.facebook.com/photo/?fbid=10247450985194970&set=gm.28690380737296532&idorvanity=718992471528734

"Early this morning, the Moon passed in front of Jupiter, blocking Jupiter for about an hour. In this image, Jupiter and four of its moons are emerging from behind the Moon. The Moon is sliding away toward the lower left. From any location on Earth, this happens about every 10-20 years. Taken from Bay Village." - Frank Shoemaker Post Oct 7 2026, so presumably the early morning of Oct 6 and Bay Village, Ohio seems to work

Actual:
Image

Celestiary:
https://celestiary.github.io/#sun/[email protected],-82.3901,169m;from=sun/earth;t=9774.891jd;cq=0.3372,-0.7003,-0.112,0.6191;fov=0.91deg;s=oL
Image

The photo may be a bit overexposed, but it's still a pretty useful level.

UI issues:

  1. track should not lock roll. 't' for track is very useful for running time forward and backwards to find the moment, but it also locks the view's roll, so i had to keep turning it off and re-rolling manually
  2. time delta should editable during pause. similar to 1, 'j', 'k' and 'l' are useful to speed up, slow down and reverse time to find the moment, but delta can't be edited during pause, which is often when you want to base from.

rendering issues:

  1. Jupiter is getting pixelated - high priority
  2. no crater roughness along the moon's terminator
  3. missing the couple of stars to the right of Jupiter seen in both, and a few other
  4. missing sky glow, tho debatable how desirable this is.. we could just simulate clear sky conditions by default. curious how much glow should be there on clearest skies tho

and another https://www.facebook.com/photo/?fbid=1701755441306341&set=a.201432234672010:
Actual:
Image

Celestiary
https://celestiary.github.io/web/pr-preview/pr-187/#sun/[email protected],-82.3901,169m;from=sun/earth;t=9774.8935jd;cq=-0.2256,-0.7506,0.3328,0.5244;fov=0.63deg;s=lpoL
Image

UI issues:

  1. Needs overall exposure control to allow boosting to fit target image

Rendering issues:

  1. Missing stars

and another for later calibration needing more stars and better white balance/exposure on the moon
Image

more at different exposures, fov (https://www.facebook.com/photo/?fbid=3132273383644659&set=gm.984224191430128&idorvanity=188931684292720):
Image

Image Image Image

"In Bavaria, it was at 12.25 here":
Image

Lingua principale
JavaScript
Stelle
55
Fork
4
Merge medio
10h 12m
PR unite (30g)
134

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di celestiary/web

Tutte le issue di celestiary/web

Issue simili

Altre issue su JavaScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.