Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Show when the SQM reading is still converging

Aperta
  • Qualcosa non va?
#601 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
72/100
Tipo di issue
Funzionalità
Chiarezza
Specificata chiaramente
Stato di attività
Tranquilla
Stack tecnologico
numpy, python, raspberry-pi
Ambito
desktop, frontend

Direzione di ricerca

Read python/PiFinder/sqm/radiometer.py:224 to understand the existing RadiometerAccumulator.estimate() details, then trace how its values reach python/PiFinder/ui/sqm.py and python/PiFinder/ui/base.py:47. Add a convergence cue to the SQM screen and title-bar readout using the existing no-data path or another presentation, while preserving the final measurement. Verify that settling and settled readings are visually distinguishable and that the existing SQM UI behavior still works.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement
Background

Field report from a user comparing PiFinder's SQM against a Unihedron SQM-L: the
final values agreed closely (21.44 vs 21.43), but panning from a bright patch of
sky to a dark one showed ~19 at first and took roughly half a minute to settle on
21.44. Because the title bar now always shows an SQM number, there is no cue
that the displayed value is still converging — it reads as a finished
measurement the whole time.

Why it happens

This is the rolling window working as designed, not a photometry fault.
RadiometerAccumulator (python/PiFinder/sqm/radiometer.py:224) publishes the
median of up to 12 radiometer samples inside a 15-second window:

max_samples: int = 12
max_age_seconds: float = 15.0
...
value = float(np.median(values))

A median does not move until more than half the window has been replaced, so
after a slew the published value stays blended across two patches of sky for the
length of the window. At night-time frame cadence that is comfortably the ~30
seconds the user observed.

Proposal

Surface the convergence state in the UI. No new photometry is required —
RadiometerAccumulator.estimate() already computes and returns both signals in
its details dict:

  • radiometer_samples — how many samples in the window were accepted
  • radiometer_frame_scatter — np.std() across the window's values

Plumb these through to the UI and render a settling cue while the window is
mixed or scatter is high. Consumers to update:

  • python/PiFinder/ui/sqm.py — the SQM screen's main value
  • python/PiFinder/ui/base.py:47 — RotatingInfoDisplay, the title-bar readout,
    which already has a "---" path for the no-data case that a settling state
    could reuse

Presentation is open — dimming the value, a small progress pip, or dashing it
until the window is coherent would all work. The requirement is only that a user
can tell "still settling" from "this is the reading".

Supersedes

This was chosen over a separate proposal to carry the measurement's RA/Dec in
state.SQM and blank the reading once the telescope moved more than 10–20°.
That approach needs a shared-state dataclass change across two processes, and it
degrades badly when there is no solve (SQM is deliberately solve-independent, so
pointing may be unknown or IMU-only). Showing convergence directly is a better
solution: it uses data the accumulator already produces, needs no pointing, and
covers every cause of an unsettled window — not just deliberate slews.

Lingua principale
Jupyter Notebook
Stelle
253
Fork
63
Merge medio
11h 55m
PR unite (30g)
8

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di brickbots/PiFinder

Tutte le issue di brickbots/PiFinder

Issue simili

Altre issue su Desktop Dev

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.