Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

psmux: probe and launch the same pwsh executable (pin one absolute path, quote it in pipe_pane)

Chiusa
  • Qualcosa non va?
#863 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Una pull request collegata è già stata integrata.

  • #9 di @dracic — integrata
  • #871 di @dracic — integrata

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
45/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
python
Ambito
cli

Direzione di ricerca

Start by reading PsmuxMultiplexer._require_pwsh_floor, _shell_wrap, and the new_session path, then inspect how pipe_pane builds its command. Trace how the executable path and argv reach both the version probe and window launch, and determine whether the initial window should remain unchanged or receive an explicit shell. Done means the probe and launch use the same resolved executable and paths with spaces survive pipe_pane quoting.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

#862 refuses PowerShell older than 7.3 before psmux launches a window. Its version probe resolves pwsh on the launching process's PATH, while the window's pwsh resolves on the psmux server's PATH. The server inherits the environment of whichever process created the session, so the two agree in every bmad-loop flow, unless an operator changes PATH between creating the session and launching. This ceiling is documented in PsmuxMultiplexer._require_pwsh_floor.

Closing it means probing and launching the same executable:

  • Resolve one absolute pwsh path, probe its version, and use that same path in _shell_wrap's window argv.
  • pipe_pane space-joins that argv, and an absolute path such as C:\Program Files\PowerShell\7\pwsh.exe contains a space. So pipe_pane needs proper quoting first, or the sidecar command breaks.
  • The session's initial window (new_session) runs psmux's own default shell, not a pwsh path bmad-loop passes. Pinning it would mean passing an explicit shell command to new-session, which changes how that window starts, so it needs its own decision.

Raised as a review finding on #862 and kept out of that PR as a separate change. Real-world risk is low: it needs a PATH change between two steps of one flow, and the floor only matters for end-of-life pwsh 7.0–7.2.

Refs #861 #862

Lingua principale
Python
Stelle
165
Fork
69
Merge medio
1g 2h
PR unite (30g)
78

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di bmad-code-org/bmad-loop

Tutte le issue di bmad-code-org/bmad-loop

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.