Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

psmux: probe and launch the same pwsh executable (pin one absolute path, quote it in pipe_pane)

Cerrado
  • ¿Algo no está bien?
#863 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Ya se ha fusionado un pull request relacionado.

  • #9 de @dracic — fusionado
  • #871 de @dracic — fusionado

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
45/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
python
Área
cli

Línea de trabajo

Start by reading PsmuxMultiplexer._require_pwsh_floor, _shell_wrap, and the new_session path, then inspect how pipe_pane builds its command. Trace how the executable path and argv reach both the version probe and window launch, and determine whether the initial window should remain unchanged or receive an explicit shell. Done means the probe and launch use the same resolved executable and paths with spaces survive pipe_pane quoting.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

#862 refuses PowerShell older than 7.3 before psmux launches a window. Its version probe resolves pwsh on the launching process's PATH, while the window's pwsh resolves on the psmux server's PATH. The server inherits the environment of whichever process created the session, so the two agree in every bmad-loop flow, unless an operator changes PATH between creating the session and launching. This ceiling is documented in PsmuxMultiplexer._require_pwsh_floor.

Closing it means probing and launching the same executable:

  • Resolve one absolute pwsh path, probe its version, and use that same path in _shell_wrap's window argv.
  • pipe_pane space-joins that argv, and an absolute path such as C:\Program Files\PowerShell\7\pwsh.exe contains a space. So pipe_pane needs proper quoting first, or the sidecar command breaks.
  • The session's initial window (new_session) runs psmux's own default shell, not a pwsh path bmad-loop passes. Pinning it would mean passing an explicit shell command to new-session, which changes how that window starts, so it needs its own decision.

Raised as a review finding on #862 and kept out of that PR as a separate change. Real-world risk is low: it needs a PATH change between two steps of one flow, and the floor only matters for end-of-life pwsh 7.0–7.2.

Refs #861 #862

Lenguaje dominante
Python
Estrellas
165
Forks
69
Merge medio
1 d 3 h
PR fusionados (30 d)
75

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de bmad-code-org/bmad-loop

Todos los issues de bmad-code-org/bmad-loop

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.