Live-table verification of the 21 Sept changes — unordered signing, single submit queue, auto hooks, sounds

Aperta
  • Qualcosa non va?
#646 4 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
42/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
blockchain, frontend, testing-qa

Direzione di ricerca

Start with a preview build of the UI and keep the console open; use the checklist to run a complete heads-up Sit & Go against the real chain. Check vercel.json and the node1 WS_OPTIMISTIC setting when investigating deployment or delayed opponent actions. Done means recording every checklist result here and opening separate issues for failures.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

ready for testing sit-and-go

Everything below merged on 21 September 2026. All of it is unit- and e2e-tested against the stub; none of it has been played against the real chain. #630 tracks the automated real-chain suite; this is the one-off manual pass to do now, before players meet it.

What changed

Change PR Risk if wrong
Gameplay txs sign unordered (SDK 1.4.1) poker-vm#2621, #641 Every action fails at CheckTx
Auto new-hand / blinds / deal through the submit queue #640 Hand never starts without a manual click
Auto fold / pre-check / show / muck through the queue, standing down while busy #643 An automatic action fires at the wrong time, or never
Sequence-mismatch retry removed from gameplay actions #641 — (dead code)
SDK methods throw on failed execution (join / leave / top-up / create / claim) poker-vm#2618 via #641 A cash-out or join that used to "succeed" silently now errors
Sounds: every action in a frame, silent blind posts, preloaded #642 Cosmetic

Pass — one heads-up Sit & Go on a preview build, console open

The bug this all started from

  • Zero account sequence mismatch and zero tx already exists in cache across the whole tournament. (Was 10 in 11 hands.)
  • Blinds post and cards deal by themselves every hand — no manual "Post Small Blind" button appearing.

Unordered signing actually works on a real node — if it does not, nothing will

  • Fold, check, call, bet, raise, all-in each land.
  • Two actions in quick succession (blind → deal → first action) all land.

The stand-down rule (#643) — the one to try hard to break

  • Let the clock run to 0 while a Call is still spinning: nothing folds.
  • Let the clock run to 0 with nothing in flight: it checks if free, otherwise folds — once.
  • Tick pre-check, then act by hand as the turn arrives: no second action fires, the box unticks.
  • Showdown with auto-muck on, and with it off (clock expiry → show).

Failures reach the player

  • Force one rejection (e.g. act from a second tab so the index goes stale): a toast appears, the action row comes back.

Money paths now throw on failure (#2618)

  • Join, top-up, leave a cash table.
  • Finish the SNG and claim the prize as each finisher — including the second claimant, whose recordHandEnd should hit the benign "already finalized" branch and still settle.

Sounds (#642)

  • An opponent's blind post is silent; no phantom check at the start of a hand.
  • Two opponents acting in one block: you hear both, in order. Does 120 ms apart sound right?
  • First sound of the session is not noticeably late.

Also unknown

  • Is main auto-deployed? There is a vercel.json but no deploy workflow and no deployment status on any commit, so it is not clear from the repo whether these merges are already in front of players.
  • WS_OPTIMISTIC on node1 (#624) — if it is off, opponents' actions and sounds arrive at block commit, ~2.5 s late, whatever the UI does.

Record results here; open separate issues for anything that fails.

Refs #635, #624, #630, block52/poker-vm#2619, block52/pokerchain#367.

Lingua principale
TypeScript
Stelle
2
Fork
5
Merge medio
22h 35m
PR unite (30g)
91

Preparare l'ambiente

Non abbiamo ancora controllato i file di configurazione di questo progetto. Parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di block52/ui

Tutte le issue di block52/ui

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.