Task page Changes view: polish after #1003

Aperta
  • Qualcosa non va?
#1,016 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
35/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
github, react, typescript
Ambito
backend-api-design, documentation, frontend, full-stack, performance, testing

Direzione di ricerca

Start with the named entry points: changes.tsx, apps/server/src/http.ts, packages/github/src/files/files.ts, task.ts, harvestedAttemptChanges, and the two READMEs; inspect the review and tests for #1003 as well. The issue asks for a batch of UI, API, cache, model, and documentation follow-ups, with tests for GitHub 404, 422, and rate-limit responses. Done means every listed behavior is addressed and the related tests and copy are updated.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement

Follow-ups from the review of #1003 (task page Changes view, #932), all P3; batch them in one PR.

  • "Checks: passed" and "Review: approved" stay visible when Compare is set to an attempt; they describe the PR head, not that attempt's commits. Hide or label them per selection.
  • With no recorded attempts, Compare is a dropdown with one option and is narrower than with attempts, so the layout shifts. Show plain text in that case.
  • The "Changes" disclosure uses the browser's default triangle while the file rows use chevron icons.
  • At phone width file paths are cut at the end ("src/transcript/reader/rea…"), hiding the file name. Truncate from the start or wrap.
  • apps/server/src/http.ts pullRequestFiles: GitHub 404 and 422 surface as 502 "GitHub returned HTTP status 404" (unknown commit, a force-pushed commit GitHub garbage-collected, an item that isn't a PR). Map them to a 404 envelope with a specific message; add tests for 404, 422 and rate limit.
  • packages/github/src/files/files.ts: a stale whole-PR selection returns 502 InvalidGitHubResponseError; a 409 describes the state.
  • Attempts that pushed nothing (base equals head) show in Compare with "No files changed"; filter them in harvestedAttemptChanges.
  • files.ts: exactly 300 compare files is flagged truncated; GitHub gives no total, so document it.
  • PRs polled before #1003 have no baseRefOid and show "Changes are available after…" until the PR changes; that copy isn't fact-first, and task.ts logs a warning on every task read for them (use debug, or refetch the payload once).
  • changes.tsx imports runtime values from @usine/github/files, which also defines the service and layer; a model-only subpath keeps server code out of the bundle.
  • The server files cache (128 entries, each up to 3,000 files with patches) has no byte bound.
  • The OpenAPI query parameter is named _tag, which leaks the discriminator into the public API.
  • apps/server/README.md and packages/orchestrator/README.md still say the range starts at the "first commit"; it starts at the recorded checkout base, and the whole-PR query needs base.
Lingua principale
TypeScript
Stelle
1
Fork
0
Merge medio
3h 47m
PR unite (30g)
388

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di basaltbytes/usine

Tutte le issue di basaltbytes/usine

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.