Task page Changes view: polish after #1003

Cerrado
  • ¿Algo no está bien?
#1,016 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Ya se ha fusionado un pull request relacionado.

  • #1060 de @usine-phildl — fusionado

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
35/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
github, react, typescript
Área
backend-api-design, documentation, frontend, full-stack, performance, testing

Línea de trabajo

Start with the named entry points: changes.tsx, apps/server/src/http.ts, packages/github/src/files/files.ts, task.ts, harvestedAttemptChanges, and the two READMEs; inspect the review and tests for #1003 as well. The issue asks for a batch of UI, API, cache, model, and documentation follow-ups, with tests for GitHub 404, 422, and rate-limit responses. Done means every listed behavior is addressed and the related tests and copy are updated.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement

Follow-ups from the review of #1003 (task page Changes view, #932), all P3; batch them in one PR.

  • "Checks: passed" and "Review: approved" stay visible when Compare is set to an attempt; they describe the PR head, not that attempt's commits. Hide or label them per selection.
  • With no recorded attempts, Compare is a dropdown with one option and is narrower than with attempts, so the layout shifts. Show plain text in that case.
  • The "Changes" disclosure uses the browser's default triangle while the file rows use chevron icons.
  • At phone width file paths are cut at the end ("src/transcript/reader/rea…"), hiding the file name. Truncate from the start or wrap.
  • apps/server/src/http.ts pullRequestFiles: GitHub 404 and 422 surface as 502 "GitHub returned HTTP status 404" (unknown commit, a force-pushed commit GitHub garbage-collected, an item that isn't a PR). Map them to a 404 envelope with a specific message; add tests for 404, 422 and rate limit.
  • packages/github/src/files/files.ts: a stale whole-PR selection returns 502 InvalidGitHubResponseError; a 409 describes the state.
  • Attempts that pushed nothing (base equals head) show in Compare with "No files changed"; filter them in harvestedAttemptChanges.
  • files.ts: exactly 300 compare files is flagged truncated; GitHub gives no total, so document it.
  • PRs polled before #1003 have no baseRefOid and show "Changes are available after…" until the PR changes; that copy isn't fact-first, and task.ts logs a warning on every task read for them (use debug, or refetch the payload once).
  • changes.tsx imports runtime values from @usine/github/files, which also defines the service and layer; a model-only subpath keeps server code out of the bundle.
  • The server files cache (128 entries, each up to 3,000 files with patches) has no byte bound.
  • The OpenAPI query parameter is named _tag, which leaks the discriminator into the public API.
  • apps/server/README.md and packages/orchestrator/README.md still say the range starts at the "first commit"; it starts at the recorded checkout base, and the whole-PR query needs base.
Lenguaje dominante
TypeScript
Estrellas
1
Forks
0
Merge medio
3 h 52 min
PR fusionados (30 d)
423

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de basaltbytes/usine

Todos los issues de basaltbytes/usine

Issues similares

Más issues de TypeScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.