[Bug]: get() on a SKIPPED parallel branch never returns, and the execution fails
I maintainer di solito rispondono entro 1 giorno
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 52/100
- Tipo di issue
- Bug
- Chiarezza
- Specificata chiaramente
- Stato di attività
- Attiva
- Stack tecnologico
- java
- Ambito
- backend, documentation, testing-qa
Direzione di ricerca
Start with ParallelOperation.handleCompletion and ParallelOperation.branch(), then inspect ChildContextOperation.handleChildContextSuccess and the sdk-integration-tests using LocalDurableTestRunner. Compare both skipped-branch cases across the first invocation and replay, and update docs/core/parallel.md as needed. Done means get() consistently returns or throws a named branch exception without producing PENDING with no pending operation.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Expected Behavior
get() on a branch future returns the branch result or throws an exception. It behaves the same way in the first invocation and on every replay.
The parallel result can record a branch as SKIPPED. For such a branch, get() should throw an exception that names the branch. docs/core/parallel.md should document it. For comparison, docs/core/map.md defines a skipped map item: status SKIPPED, a null result, and a null error.
Actual Behavior
get() on a SKIPPED branch does not return, and it does not throw a branch exception. It waits until the SDK suspends the invocation. The invocation then returns PENDING with no pending operation. In the cloud, the service rejects that output with InvalidParameterValueException: Cannot return PENDING status with no pending operations., the same error as in #736. Every replay reaches the same state, so the execution fails.
This happens in two cases.
Case 1: the branch never started.
- A completion config such as
firstSuccessful()completes the parallel before every branch has started. ParallelOperation.handleCompletionrecords each branch whose future is not complete asSKIPPED.- The SDK does not start that branch later. Nothing completes its future until the SDK suspends the invocation.
get()on the branch releases the calling thread and waits. If no other thread is active, the SDK suspends the invocation. The suspension ends the wait with the SDK's internalSuspendExecutionException.- On replay,
ParallelOperation.branch()readsSKIPPEDfrom the checkpointed result and does not queue the branch. So every replay repeats steps 3 and 4.
Case 1 needs no race, and it fails in the first invocation. The repro uses firstSuccessful(). handleCompletion applies the same rule for every completion config that can complete early: minSuccessful(n), allSuccessful(), toleratedFailureCount(n), and shouldComplete(...).
Case 2: the branch was still running when the parallel completed.
- With unlimited concurrency, branch-b can still be running when branch-a completes the parallel. The checkpointed result records branch-b as
SKIPPED. - branch-b finishes later in the same invocation.
ChildContextOperation.handleChildContextSuccessdoes not checkpoint the result, because the parallel is already complete.get()returns the result from memory. - A later operation, such as a wait, suspends the invocation. The next invocation replays the handler.
- On replay,
ParallelOperation.branch()readsSKIPPEDand does not run branch-b. Theget()call that returned a value in the first invocation now waits until the SDK suspends, as in case 1.
In case 2, the same handler code returns a value in the first invocation and fails on replay.
Steps to Reproduce
Both cases run in sdk-integration-tests with LocalDurableTestRunner.
Case 1 is the basic pattern from docs/core/parallel.md with firstSuccessful():
var runner = LocalDurableTestRunner.create(String.class, (input, context) -> {
var config = ParallelConfig.builder()
.maxConcurrency(1)
.completionConfig(CompletionConfig.firstSuccessful())
.build();
var parallel = context.parallel("first-successful", config);
var a = parallel.branch("branch-a", String.class, ctx -> "A");
var b = parallel.branch("branch-b", String.class, ctx -> "B");
parallel.get(); // MIN_SUCCESSFUL_REACHED, statuses [SUCCEEDED, SKIPPED]
a.get(); // "A"
return b.get(); // never returns a value or throws a branch exception
});
var result = runner.runUntilComplete("input");
assertEquals(ExecutionStatus.PENDING, result.getStatus());
The result has status PENDING and no error. The execution state holds first-successful (Parallel, SUCCEEDED) and branch-a (ParallelBranch, SUCCEEDED). No operation is pending. The invocation logs Invalid suspension. No operation is pending. Each further runner.run("input") gives the same result. The outcome is the same with NestingType.FLAT, and with DurableFuture.allOf(...) over both branches in place of b.get().
Case 2 uses unlimited concurrency. A wait after the parallel forces a replay:
var runner = LocalDurableTestRunner.create(String.class, (input, context) -> {
var config = ParallelConfig.builder()
.completionConfig(CompletionConfig.firstSuccessful())
.build();
var parallel = context.parallel("first-successful", config);
var a = parallel.branch("branch-a", String.class, ctx -> sleepThen(200, "A"));
var b = parallel.branch("branch-b", String.class, ctx -> sleepThen(1000, "B"));
parallel.get(); // statuses [SUCCEEDED, SKIPPED]: branch-b is still running
var value = a.get() + b.get(); // "AB" in the first invocation
context.wait("pause", Duration.ofSeconds(1)); // any later suspension causes a replay
return value;
});
runner.run("input"); // invocation 1
runner.advanceTime(); // completes "pause"
runner.run("input"); // invocation 2, a replay
sleepThen(ms, value) calls Thread.sleep(ms) and returns value.
| Invocation | a.get() + b.get() |
Output | Pending operations |
|---|---|---|---|
| 1 | returns "AB" |
PENDING |
1 (pause) |
| 2 | does not return | PENDING, no error |
0 |
| 3 and 4 | does not return | PENDING, no error |
0 |
Invocations 2 to 4 each log Invalid suspension. No operation is pending. The outcome is the same with NestingType.FLAT.
SDK Version
2.2.1. Reproduced on main at ef88276 (2.2.2-SNAPSHOT). No file under sdk/src/main changed between v2.2.1 and ef88276.
Java Version
21
Is this a regression?
Unknown
Additional Context
- #736 listed this as a follow-up: "Make
get()on a persisted skipped branch fail explicitly instead of waiting forever." #737 fixed the race in #736 and did not change this behavior. #736 described the replay of a persisted result. Case 1 also fails in the first invocation. - A fix for case 2 has to make the first invocation and the replay agree. One option:
get()throws for every branch that the checkpointed result records asSKIPPED, including a branch that finished later in the first invocation. Another option: the SDK checkpoints a late branch result so that replay returns it. - The
ParallelResulttable indocs/core/parallel.mddoes not listskipped()orstatuses(). - The end state,
PENDINGwith no pending operation, is the state that #370 and #736 also reached. How the SDK reports that state is a separate issue.
- Lingua principale
- Java
- Stelle
- 28
- Fork
- 14
- Merge medio
- 2g 13h
- PR unite (30g)
- 47
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di aws/aws-durable-execution-sdk-java
-
documentation pkg:sdk
Difficoltà 1/5 1-3 ore Idoneità per principianti 88/100
aws/aws-durable-execution-sdk-java#645 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
enhancement
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
aws/aws-durable-execution-sdk-java#300 ·
I maintainer di solito rispondono entro 1 giorno
-
enhancement needs-triage
Difficoltà 5/5 Più di una settimana Idoneità per principianti 35/100
aws/aws-durable-execution-sdk-java#779 ·
I maintainer di solito rispondono entro 1 giorno
-
[Bug]: root handler instrumentation misses the canonical OTel execution contextForse già presa @zhongkechen l’ha presa 4 giorni fa. Apertaneeds-triage
Difficoltà 5/5 Più di una settimana Idoneità per principianti 40/100
aws/aws-durable-execution-sdk-java#770 ·
I maintainer di solito rispondono entro 1 giorno
-
[Feature]: Propagate per-operation trace context for chained invokesForse già presa Una pull request collegata a questa issue è aperta o già unita. Apertaenhancement needs-triage
Difficoltà 5/5 Più di una settimana Idoneità per principianti 38/100
aws/aws-durable-execution-sdk-java#764 ·
I maintainer di solito rispondono entro 1 giorno
Tutte le issue di aws/aws-durable-execution-sdk-java
Issue simili
-
Bump up AWS SDK to 2.54.3Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 68/100
jenkinsci/ec2-plugin#2041 ·
-
L: github:actions L: php:composer
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
dependabot/dependabot-core#16493 ·
I maintainer di solito rispondono entro 1 giorno
-
SHOW EDIT of a subclass for an object of its superclass: the form fails to open with AssertionErrorAperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 72/100
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 78/100
FlashyReese/sodium-extra#608 ·