[Bug] Proxy remoting server shutdown leaves the expired-request timer running

Aperta
  • Qualcosa non va?
#11,456 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

@iloveeyjafjalla ci sta già lavorando.

Dal 20/10/2026.

  • #11457 di @iloveeyjafjalla — aperta

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
25/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Ferma
Stack tecnologico
java
Ambito
backend, distributed-systems

Direzione di ricerca

Read RemotingProtocolServer and trace how its constructor creates timerExecutor and how shutdown() handles the remoting executors. The issue reports that linked pull request #11457 addresses the lifecycle bug; inspect its changes and tests to confirm the expected shutdown behavior.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Before Creating the Bug Report
  • I have searched the open issues of this repository and believe that this is not a duplicate.
  • This is a defect in Apache RocketMQ, not a usage question.
  • I can reproduce this on the current develop branch.
RocketMQ Version

develop @ 57c2dc04f78cc7e73e6b8c9436ee0fff0d0f46c3 (the revision this was verified on)

Describe the Bug

RemotingProtocolServer schedules the expired-request cleanup in its constructor:

this.timerExecutor = ThreadUtils.newSingleThreadScheduledExecutor(
    new ThreadFactoryBuilder().setNameFormat("RemotingServerScheduler-%d").build()
);
this.timerExecutor.scheduleAtFixedRate(this::cleanExpireRequest, 100, 100, TimeUnit.MILLISECONDS);

ThreadFactoryBuilder produces non-daemon threads, and shutdown() stops the eight remoting executors but not this one:

this.defaultRemotingServer.shutdown();
this.remotingChannelManager.shutdown();
this.sendMessageExecutor.shutdown();
this.pullMessageExecutor.shutdown();
this.heartbeatExecutor.shutdown();
this.updateOffsetExecutor.shutdown();
this.topicRouteExecutor.shutdown();
this.defaultExecutor.shutdown();
// timerExecutor is never stopped

So a proxy whose remoting server has been shut down keeps a live thread running cleanExpireRequest every 100 ms against the stopped server, and the non-daemon thread keeps the JVM alive after the Spring context has closed instead of letting the process exit.

This is the same shape as #11427: a service created in a constructor is started but not stopped by the owner's shutdown path.

Steps to Reproduce
  1. Start the proxy and stop it again (or close its Spring context in a test).
  2. jstack shows the RemotingServerScheduler-1 thread still alive after RemotingProtocolServer.shutdown() returned, and the process does not exit on its own.
  3. The added test shows the same point without a proxy: with the current code verify(timerExecutor).shutdown() fails with Wanted but not invoked.
What Did You Expect to See?

shutdown() stops the executor it scheduled in the constructor, like the eight remoting executors it already stops, so nothing of the server survives the shutdown.

What Did You See Instead?

The timer thread survives the shutdown, keeps running the 100 ms cleanup task, and keeps the JVM alive.

Additional Context

#10806 reports a different problem in the same class (the cleanup loop swallows exceptions); this one is about the executor's lifecycle.

Lingua principale
Java
Stelle
22.7k
Fork
12k
Merge medio
4g 20h
PR unite (30g)
11

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di apache/rocketmq

Tutte le issue di apache/rocketmq

Issue simili

Altre issue su Java

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.