[Bug] Proxy remoting server shutdown leaves the expired-request timer running

Abierto
  • ¿Algo no está bien?
#11,456 1 comentario 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@iloveeyjafjalla ya está trabajando en esto.

Desde el 20/10/2026.

  • #11457 de @iloveeyjafjalla — abierto

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
25/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Estancado
Stack tecnológico
java
Área
backend, distributed-systems

Línea de trabajo

Read RemotingProtocolServer and trace how its constructor creates timerExecutor and how shutdown() handles the remoting executors. The issue reports that linked pull request #11457 addresses the lifecycle bug; inspect its changes and tests to confirm the expected shutdown behavior.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Before Creating the Bug Report
  • I have searched the open issues of this repository and believe that this is not a duplicate.
  • This is a defect in Apache RocketMQ, not a usage question.
  • I can reproduce this on the current develop branch.
RocketMQ Version

develop @ 57c2dc04f78cc7e73e6b8c9436ee0fff0d0f46c3 (the revision this was verified on)

Describe the Bug

RemotingProtocolServer schedules the expired-request cleanup in its constructor:

this.timerExecutor = ThreadUtils.newSingleThreadScheduledExecutor(
    new ThreadFactoryBuilder().setNameFormat("RemotingServerScheduler-%d").build()
);
this.timerExecutor.scheduleAtFixedRate(this::cleanExpireRequest, 100, 100, TimeUnit.MILLISECONDS);

ThreadFactoryBuilder produces non-daemon threads, and shutdown() stops the eight remoting executors but not this one:

this.defaultRemotingServer.shutdown();
this.remotingChannelManager.shutdown();
this.sendMessageExecutor.shutdown();
this.pullMessageExecutor.shutdown();
this.heartbeatExecutor.shutdown();
this.updateOffsetExecutor.shutdown();
this.topicRouteExecutor.shutdown();
this.defaultExecutor.shutdown();
// timerExecutor is never stopped

So a proxy whose remoting server has been shut down keeps a live thread running cleanExpireRequest every 100 ms against the stopped server, and the non-daemon thread keeps the JVM alive after the Spring context has closed instead of letting the process exit.

This is the same shape as #11427: a service created in a constructor is started but not stopped by the owner's shutdown path.

Steps to Reproduce
  1. Start the proxy and stop it again (or close its Spring context in a test).
  2. jstack shows the RemotingServerScheduler-1 thread still alive after RemotingProtocolServer.shutdown() returned, and the process does not exit on its own.
  3. The added test shows the same point without a proxy: with the current code verify(timerExecutor).shutdown() fails with Wanted but not invoked.
What Did You Expect to See?

shutdown() stops the executor it scheduled in the constructor, like the eight remoting executors it already stops, so nothing of the server survives the shutdown.

What Did You See Instead?

The timer thread survives the shutdown, keeps running the 100 ms cleanup task, and keeps the JVM alive.

Additional Context

#10806 reports a different problem in the same class (the cleanup loop swallows exceptions); this one is about the executor's lifecycle.

Lenguaje dominante
Java
Estrellas
22.7k
Forks
12k
Merge medio
4 d 20 h
PR fusionados (30 d)
11

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de apache/rocketmq

Todos los issues de apache/rocketmq

Issues similares

Más issues de Java

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.