[EPIC] Faster manifest reads through pyiceberg-core
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Idoneità per principianti
- 25/100
- Tipo di issue
- Funzionalità
- Chiarezza
- Abbastanza chiara
- Stato di attività
- Attiva
- Ambito
- backend, data-engineering, databases
Direzione di ricerca
Start with the task list and the referenced entry points: ManifestWriter.add_entry in pyiceberg/manifest.py, inspect.entries() and inspect.files() in pyiceberg/table/inspect.py, and _open_manifest in pyiceberg/table/init.py. Read iceberg-rust#3262 and confirm the required pyiceberg-core Arrow output and release dependency. Done means the selected manifest-reading paths use the faster output while retaining the Cython fallback and matching existing results and benchmarks.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Feature Request / Improvement
PyIceberg reads manifests and manifest lists with its Cython Avro decoder. pyiceberg-core (the iceberg-rust Python binding) already exposes read_manifest_entries and read_manifest_list, but using them today makes manifest reads 4x to 5x slower than Cython. This issue tracks the work in both repos to make the pyiceberg-core path faster than Cython, and then to switch PyIceberg to it. The iceberg-rust side is tracked in apache/iceberg-rust#3262, which repeats those tasks in more detail.
The earlier attempt (apache/iceberg-rust#1280, apache/iceberg-python#2493) was closed. It converted every Rust manifest entry into a PyIceberg DataFile in Python, which is the rust_convert path measured below. The full benchmark writeup from @kevinjqliu, including an in-crate profile of the Rust parser and the script, is in https://github.com/kevinjqliu/iceberg-python/issues/45.
Where the time goes
These numbers come from manifests written by PyIceberg (V2, deflate, 12 columns with full column stats, identity partition). pyiceberg is at main (0d58407) with the Cython decoder. pyiceberg-core is built locally from the v0.10.1 tag, once as released (opt-level = "z") and once with opt-level = 3. Each number is the best of 7 runs in ms, single threaded, on Apple Silicon with Python 3.12. v0.10.1 predates apache/iceberg-rust#3028, which its PR measured as making the Rust parse about 5% faster.
| entries | Cython | pyiceberg-core as released |
pyiceberg-core with opt-level = 3 |
|---|---|---|---|
| 1,000 | 8.7 | 43.9 | 30.8 |
| 10,000 | 94.1 | 452.3 | 320.4 |
| 50,000 | 565.9 | 2308.7 | 1628.0 |
The pyiceberg-core columns include building PyIceberg ManifestEntry and DataFile objects, so all three columns produce the same result. At 10,000 entries with opt-level = 3, the Rust parse costs 21.7 us per entry and converting the result into PyIceberg objects costs another 10.3 us per entry. The whole Cython path costs 10.3 us per entry in the same run. The conversion alone costs as much as Cython, so a faster Rust parser can't reach parity unless PyIceberg also stops building one Python object per entry from the binding's output.
Manifest lists are closer. With opt-level = 3 the Rust parse of a 10,000-entry manifest list takes 8.0 ms against 23.9 ms for Cython, and the conversion into ManifestFile objects is what makes the end-to-end path slower (39.1 ms).
Task list
These tasks are in PyIceberg.
- Write
equality_idsaslist<int>per the spec. PR: #3842. - Flush manifest entries in size-bounded Avro blocks.
ManifestWriter.add_entrycallswrite_blockonce per entry (manifest.py#L1213-L1238), so every entry gets its own deflate stream and sync marker. Java writes manifests through Avro'sDataFileWriterand keeps its default sync interval, which the linked issue reports as 64 KB. In the linked benchmark, a 10,000-entry manifest shrank from 3.6 MB to 0.7 MB and read about 1.5x faster with both decoders after re-encoding with 64 KB blocks. The manifest-list writer already writes one block (manifest.py#L1389). This task doesn't depend on anything else. PR: https://github.com/apache/iceberg-python/pull/4008 - Build
inspect.entries()andinspect.files()frompyiceberg-coreArrow output. Both methods build aDataFileper entry and then flatten them back into apa.Table(inspect.py#L152,inspect.py#L860). These are the first consumer of the Arrow output from the iceberg-rust tasks, because they want Arrow anyway. This task depends on that output being in apyiceberg-corerelease. - Plan scans through
pyiceberg-core._open_manifest(table/__init__.py#L2321-L2334) filters each entry with Python partition and metrics evaluators while decoding (#3658), but every entry still becomes aDataFilebefore it is filtered. To beat Cython, filtering has to happen on Arrow columns or inside Rust, so that only the matching entries become Python objects. Which of the two to use is open and is settled together with the iceberg-rust task for filtering.pyiceberg-coreis an optional extra, so the Cython reader stays as the fallback. - Read manifest lists through
pyiceberg-core. This uses the same approach as scan planning, applied toread_manifest_list.
These tasks are in iceberg-rust and tracked in apache/iceberg-rust#3262.
- Faster manifest parsing. Upgrade to
apache-avro0.22 and decode entries directly from the writer schema instead of throughapache_avro::Valueand schema resolution (apache/iceberg-rust#3063). - Build the
pyiceberg-corewheel withopt-level = 3. In the numbers above, this makes the parse about 1.6x faster and the end-to-end path about 1.4x faster. It also nearly doubles the wheel size. - Return manifest entries and manifest lists as Arrow from
pyiceberg-core. - Release
pyiceberg-corewith the above. PyIceberg pinspyiceberg-core>=0.10.1,<0.11.0.
- Lingua principale
- Python
- Stelle
- 1.1k
- Fork
- 589
- Merge medio
- 1g 20h
- PR unite (30g)
- 68
Guida per i contributori
Nessuna guida per i contributori indicizzata per questo repository
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di apache/iceberg-python
-
kind:bug
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 92/100
apache/iceberg-python#4006 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
apache/iceberg-python#3996 ·
-
Deletion vector bitmap count is read from the blob and used as a loop bound without validation Apertabug
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
apache/iceberg-python#3979 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
apache/iceberg-python#3885 ·
-
[Bug] PyArrowFileIO fails to propagate s3.ssl.ca-cert to pyarrow.fs.S3FileSystem tls_ca_file_path Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
apache/iceberg-python#3866 · 1 commento ·
Tutte le issue di apache/iceberg-python
Issue simili
-
bug confirmed issue
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
open-webui/open-webui#30750 · 1 commento ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
-
enhancement
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
OpenwaterHealth/openmotion-bloodflow-app#604 · 1 commento ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 70/100
-
good first issue
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 90/100