Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Dynamic config DELETE should fall back to the default value, not the server.yaml startup value

Aperta
  • Qualcosa non va?
#4,627 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 2 giorni

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
28/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
java
Ambito
api, backend

Direzione di ricerca

Start from the server-side handling of AlterConfigOpType.DELETE for dynamic cluster configs, and from Admin.alterClusterConfigs() and describeClusterConfigs() as the entry points. Trace where the startup value from server.yaml is kept alongside dynamic overrides. The issue leaves open whether to change DELETE or add a RESET_TO_DEFAULT op, so confirm the direction with a maintainer first. Done means a deleted key reverts to the Fluss default and is no longer listed as DYNAMIC_SERVER_CONFIG, including the same-value case.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Search before asking
  • I searched in the issues and found nothing similar.
Motivation

Today, Admin.alterClusterConfigs() with AlterConfigOpType.DELETE removes a dynamic override, and the server falls back to the value it read from server.yaml at startup. Only when the key is absent from server.yaml does it fall back to the Fluss default. A startup value cannot be removed through the API at all; only a restart with an edited server.yaml removes it.

This is a problem for tooling that owns server.yaml, such as a Kubernetes operator that renders the file from a custom resource and pushes dynamic keys through the Admin API. When a user removes a dynamic key from the resource, the tool rewrites server.yaml for the next restart, but it has no way to apply the removal to the running servers:

  • If the key was only in server.yaml, there is no override to delete, and the server keeps the old value.
  • If the key was changed since startup, DELETE drops the override, and the server goes back to the old startup value instead of the default.

In both cases the running cluster keeps a value the user removed, and a full rolling restart is the only way to apply a change to a key that is meant to be dynamic.

Example, with kv.snapshot.interval: 10min in server.yaml:

  1. SET kv.snapshot.interval=20min: the server uses 20min.
  2. DELETE kv.snapshot.interval: the server uses 10min again, not the default.
Solution

Make DELETE remove the key's effective value entirely, so the server uses the Fluss default whether or not server.yaml sets the key. describeClusterConfigs() would then list nothing for that key.

If changing DELETE itself is a compatibility concern, an explicit opt-in gives the same result, for example a new AlterConfigOpType such as RESET_TO_DEFAULT, which removes both the override and the startup value of a dynamic key.

Anything else?

A related issue appears in 1.0.0. If an override is set to the same value as the startup value and then deleted, the deletion is skipped and the override stays listed as DYNAMIC_SERVER_CONFIG. The change above would remove that case too.

Willingness to contribute
  • I'm willing to submit a PR!
Lingua principale
Java
Stelle
2.2k
Fork
658
Merge medio
3g 1h
PR unite (30g)
120

Preparare l'ambiente

  • Nessun Dockerfile né file Docker Compose
  • Ha un modello di pull request
  • Nessuna guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di apache/fluss

Tutte le issue di apache/fluss

Issue simili

Altre issue su Java

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.