Dynamic config DELETE should fall back to the default value, not the server.yaml startup value
Los mantenedores suelen responder en 2 días
Nadie ha tomado este issue todavía.
Evaluación
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Aptitud para principiantes
- 28/100
Línea de trabajo
Start from the server-side handling of AlterConfigOpType.DELETE for dynamic cluster configs, and from Admin.alterClusterConfigs() and describeClusterConfigs() as the entry points. Trace where the startup value from server.yaml is kept alongside dynamic overrides. The issue leaves open whether to change DELETE or add a RESET_TO_DEFAULT op, so confirm the direction with a maintainer first. Done means a deleted key reverts to the Fluss default and is no longer listed as DYNAMIC_SERVER_CONFIG, including the same-value case.
Escrito por el modelo de indexación a partir del texto del issue.
Descripción
Search before asking
- I searched in the issues and found nothing similar.
Motivation
Today, Admin.alterClusterConfigs() with AlterConfigOpType.DELETE removes a dynamic override, and the server falls back to the value it read from server.yaml at startup. Only when the key is absent from server.yaml does it fall back to the Fluss default. A startup value cannot be removed through the API at all; only a restart with an edited server.yaml removes it.
This is a problem for tooling that owns server.yaml, such as a Kubernetes operator that renders the file from a custom resource and pushes dynamic keys through the Admin API. When a user removes a dynamic key from the resource, the tool rewrites server.yaml for the next restart, but it has no way to apply the removal to the running servers:
- If the key was only in
server.yaml, there is no override to delete, and the server keeps the old value. - If the key was changed since startup,
DELETEdrops the override, and the server goes back to the old startup value instead of the default.
In both cases the running cluster keeps a value the user removed, and a full rolling restart is the only way to apply a change to a key that is meant to be dynamic.
Example, with kv.snapshot.interval: 10min in server.yaml:
SET kv.snapshot.interval=20min: the server uses 20min.DELETE kv.snapshot.interval: the server uses 10min again, not the default.
Solution
Make DELETE remove the key's effective value entirely, so the server uses the Fluss default whether or not server.yaml sets the key. describeClusterConfigs() would then list nothing for that key.
If changing DELETE itself is a compatibility concern, an explicit opt-in gives the same result, for example a new AlterConfigOpType such as RESET_TO_DEFAULT, which removes both the override and the startup value of a dynamic key.
Anything else?
A related issue appears in 1.0.0. If an override is set to the same value as the startup value and then deleted, the deletion is skipped and the override stays listed as DYNAMIC_SERVER_CONFIG. The change above would remove that case too.
Willingness to contribute
- I'm willing to submit a PR!
- Lenguaje dominante
- Java
- Estrellas
- 2.2k
- Forks
- 658
- Merge medio
- 3 d 2 h
- PR fusionados (30 d)
- 119
Preparar el entorno
- Sin Dockerfile ni archivo de Docker Compose
- Tiene una plantilla de pull request
- Sin guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Más de apache/fluss
-
[helm] Publish not-ready addresses on the tablet headless Service so restarting servers stay resolvablePosiblemente ocupada @morazow la tomó hoy. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 76/100
apache/fluss#4911 · 4 comentarios · 1 asignado ·
Los mantenedores suelen responder en 2 días
-
[lake/iceberg] Reserved write-mode properties can be set and reset through their `iceberg.` keyPosiblemente ocupada @aphenix-r7 la tomó hace 13 días. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 82/100
apache/fluss#4658 · 1 comentario ·
Los mantenedores suelen responder en 2 días
-
[common] Decimal#hashCode is inconsistent with Decimal#equalsPosiblemente ocupada @firasbouzazi la tomó hace 25 días. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
apache/fluss#4538 · 1 comentario ·
Los mantenedores suelen responder en 2 días
-
[security] PlainSaslServerProvider conflicts with Hadoop SASL provider causing authentication failurePosiblemente ocupada @xinzhang-hello la tomó hace 31 días. Abierto
Dificultad 1/5 Menos de una hora Aptitud para principiantes 88/100
Los mantenedores suelen responder en 2 días
-
[server] KV snapshot scheduling stops permanently after a transient snapshot-init failurePosiblemente ocupada @zhang-arvin la tomó hace 31 días. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 88/100
apache/fluss#4489 · 1 comentario ·
Los mantenedores suelen responder en 2 días
Todos los issues de apache/fluss
Issues similares
-
Preventions: a dose saved without a unit reopens blank, and an unchanged save then erases itAbiertopriority: medium Review effort [1-5]: 3 status: needs-triage type: bug
Dificultad 2/5 1-3 horas Aptitud para principiantes 78/100
carlos-emr/carlos#5431 ·
Los mantenedores suelen responder en 1 día
-
Integration tests: jetty:run fails with WELD-001408 for CountryJpaServicePosiblemente ocupada @viniciusmachak la tomó hoy. Abierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 66/100
primefaces/primefaces#15431 ·
Los mantenedores suelen responder en 1 día
-
Dificultad 2/5 1-3 horas Aptitud para principiantes 80/100
OpenAPITools/openapi-generator#25454 ·
Los mantenedores suelen responder en 1 día
-
Component - Build
Dificultad 2/5 1-3 horas Aptitud para principiantes 75/100
Los mantenedores suelen responder en 1 día
-
Update the Russian localizationAbierto
Dificultad 2/5 1-3 horas Aptitud para principiantes 62/100