[Bug][e2e] Several plugin e2e tests fail on a fresh database because they depend on tables created by other tests
I maintainer di solito rispondono entro 2 giorni
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 35/100
Direzione di ricerca
Start with e2ehelper.DataFlowTester and the failing TestCalculateCLTimeDataFlow in plugins/dora/e2e/, then check scripts/e2e-test-go-plugins.sh to see the shared-database order. Reproduce on an empty database with go test -count=1 ./plugins/<plugin>/e2e/..., and make each test create the tables its subtasks read or write. Done means every listed package and test passes alone on a fresh database.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Search before asking
- I had searched in the issues and found no similar issues.
What happened
Several Go plugin e2e tests fail when they run on a fresh, empty database, for example when you run one plugin's e2e package or one test on its own:
--- FAIL: TestCalculateCLTimeDataFlow
panic: failed to batch fetch first reviews (500)
Wraps: (3) Error 1146 (42S02): Table 'lake_test.accounts' doesn't exist
e2ehelper.DataFlowTester runs no migrations. A test only has the tables it flushes or imports. Some tests run subtasks that read or write other tables, for example a converter that deletes old board_issues rows, or a query that joins accounts. Those tables exist in CI only because an earlier test created them: scripts/e2e-test-go-plugins.sh runs every plugin's e2e package in go list order on one shared database.
Packages that fail on their own (fresh database per package):
| Package | Missing table | Test |
|---|---|---|
dora/e2e |
accounts |
TestCalculateCLTimeDataFlow (the first review query joins accounts since #9000) |
customize/e2e |
board_issues |
TestImportIssueChangelogDataFlow, TestImportIssueCommitDataFlow |
gitlab/e2e |
issue_labels |
TestGitlabIssueDataFlow |
opsgenie/e2e |
board_issues |
TestIncidentDataFlow |
pagerduty/e2e |
board_issues |
TestIncidentDataFlow |
teambition/e2e |
board_sprints |
TestTeambitionSprints |
Tests that fail with go test -run <Test> (fresh database per test), because an earlier test in the same package created the tables:
customize:TestImportIssueWorklogDataFlowgitlab:TestGitlabMrDataFlow,TestGitlabMrDetailDataFlow,TestGitlabMrNoteDataFlowteambition:TestTeambitionTaskbitbucket:TestCommentDataFlowgithub:TestMilestoneDataFlow,TestPrReviewDataFlowjira:TestEpicDataflow,TestIssueRelationshipDataFlow,TestIssueSubtaskWithoutMappinglinear:TestLinearIssueHistoryDataFlowtapd:TestTapdBugCustomizeDueDate,TestTapdStoryCustomizeDueDate,TestTapdTaskCustomizeDueDate
Some of these tests also read data that an earlier test left behind, not only the table:
- The bitbucket issue comment converter joins
_tool_bitbucket_issues, whichaccount_test.gofills. - The tapd due date tests use the statuses and workitem types that the test before them imports.
Also, the DORA fixture has no bot account, so nothing in the e2e tests covers the bot exclusion added in #9000.
What do you expect to happen
Each e2e package and each e2e test passes on a fresh database. A test sets up every table its subtasks use and does not depend on the order tests run in.
How to reproduce
- Create an empty MySQL database.
- From
backend/:
export E2E_DB_URL='mysql://merico:[email protected]:3306/lake_test?charset=utf8mb4&parseTime=True&loc=UTC'
TZ=UTC go test -count=1 ./plugins/dora/e2e/...
The other packages fail the same way. For the per-test failures, run e.g. go test -count=1 -run '^TestCommentDataFlow$' ./plugins/bitbucket/e2e/ on an empty database.
Anything else
CI passes today only because of the order the tests run in. It would break if the e2e tests ran in parallel or on a database per package.
Version
main (4ad2f66df)
Are you willing to submit PR?
- Yes I am willing to submit a PR!
Code of Conduct
- I agree to follow this project's Code of Conduct
- Lingua principale
- Go
- Stelle
- 3.2k
- Fork
- 824
- Merge medio
- 2g 22h
- PR unite (30g)
- 43
Preparare l'ambiente
Avvia il container di sviluppo del progetto nel browser, con il tuo account GitHub.
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Nessuna guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di apache/devlake
-
Difficoltà 4/5 3-5 giorni Idoneità per principianti 25/100
I maintainer di solito rispondono entro 2 giorni
-
[Bug][Project] Invalid metric plugin options are accepted on project save and only fail at the next pipeline runForse già presa @chenwei791129 l’ha presa 2 giorni fa. Aperta
Difficoltà 3/5 Mezza giornata Idoneità per principianti 22/100
I maintainer di solito rispondono entro 2 giorni
-
[Bug][Dashboard] Engineering Throughput PR time panels count PRs without a project_pr_metrics row as 0 hoursForse già presa @chenwei791129 l’ha presa 2 giorni fa. Aperta
Difficoltà 3/5 Mezza giornata Idoneità per principianti 22/100
I maintainer di solito rispondono entro 2 giorni
-
[Feature][dora] Allow filtering which pull requests count toward Lead Time for Changes by branch nameForse già presa @chenwei791129 l’ha presa 1 giorno fa. Aperta
Difficoltà 5/5 Più di una settimana Idoneità per principianti 15/100
I maintainer di solito rispondono entro 2 giorni
-
Difficoltà 3/5 Mezza giornata Idoneità per principianti 62/100
I maintainer di solito rispondono entro 2 giorni
Tutte le issue di apache/devlake
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
keyxmakerx/Chronicle#1469 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
Gentleman-Programming/gentle-ai#5565 · 1 commento ·
I maintainer di solito rispondono entro 1 giorno
-
bug frontend grammar sev-3
Difficoltà 2/5 1-3 ore Idoneità per principianti 63/100
-
connector docs good first issue
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
soma-intelligence/open-health-sync#134 ·
I maintainer di solito rispondono entro 1 giorno
-
bug frontend
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
I maintainer di solito rispondono entro 3 giorni