T27-23 — Track the originating tool in plotted-draft state, and cover it with regression tests

Aperta
  • Qualcosa non va?
#46 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
75/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
rust
Ambito
desktop, testing

Direzione di ricerca

Read the plotted-draft state and tool-switch path in crates/app/src/editor.rs, especially the review finding at lines 3271-3276. Add regression coverage for Pen → Hotspot and Hotspot → Pen, confirming each test fails with the old behavior; then run cargo test -p app. Done means the draft records its owning tool and switching tools resets or explicitly converts it, with the fix committed alongside its receipt.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

release

T27 row: T27-23
Work package: RP-00 — Inventory, release contract, baseline, task ledger (Phase-2: PR #8 remediation)
Priority: P0
Status: NOT STARTED

Objective

Make the in-progress plotted draft record which tool owns it, so points drawn with one tool cannot be silently folded into a commit made by another.

Acceptance criteria: Draft state records its owning plotting tool; switching tools resets the draft or explicitly converts it; regression tests cover Pen → Hotspot and Hotspot → Pen, and fail against the pre-fix behaviour.

Inputs

crates/app/src/editor.rs (the plotted-draft state and the tool-switch path); the PR #8 review finding on editor.rs:3271-3276.

Authority

The PR #8 review (CodeRabbit Major, data integrity); the repo's rule that a review finding is verified against current code before it is fixed.

Stopping condition

The tests exist, they fail on the old behaviour and pass on the new, and the fix is committed with its receipt.

Verification

cargo test -p app

Evidence and blockers

The finding is real and specific: CodeRabbit's Major on crates/app/src/editor.rs:3271-3276 reports that Pen-drawn points are folded into a Hotspot commit, because the plotted-draft state does not record which tool owns it. PR #8 is still open, and the campaign's P2.4 items "Track the originating tool in draft state", "Reset or explicitly convert drafts on tool changes" and "Add regression tests for Pen-to-Hotspot and reverse switching" are all unchecked.

No fix or regression test exists on any branch yet.

Blocker: none.

Ledger: docs/tasks/T27-23-draft-tool-ownership.md and docs/release/EXECUTION-BOARD.md row T27-23 (these land with PR #12).
Campaign: docs/planning/release-compaign/Cross-Platform Releas.txt.

Lingua principale
Rust
Stelle
11
Fork
1
Merge medio
9h 48m
PR unite (30g)
13

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di aliasfoxkde/FireCraft

Tutte le issue di aliasfoxkde/FireCraft

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.