T27-23 — Track the originating tool in plotted-draft state, and cover it with regression tests

Abierto
  • ¿Algo no está bien?
#46 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
3/5
Tiempo estimado
1-2 días
Aptitud para principiantes
75/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
rust
Área
desktop, testing

Línea de trabajo

Read the plotted-draft state and tool-switch path in crates/app/src/editor.rs, especially the review finding at lines 3271-3276. Add regression coverage for Pen → Hotspot and Hotspot → Pen, confirming each test fails with the old behavior; then run cargo test -p app. Done means the draft records its owning tool and switching tools resets or explicitly converts it, with the fix committed alongside its receipt.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

release

T27 row: T27-23
Work package: RP-00 — Inventory, release contract, baseline, task ledger (Phase-2: PR #8 remediation)
Priority: P0
Status: NOT STARTED

Objective

Make the in-progress plotted draft record which tool owns it, so points drawn with one tool cannot be silently folded into a commit made by another.

Acceptance criteria: Draft state records its owning plotting tool; switching tools resets the draft or explicitly converts it; regression tests cover Pen → Hotspot and Hotspot → Pen, and fail against the pre-fix behaviour.

Inputs

crates/app/src/editor.rs (the plotted-draft state and the tool-switch path); the PR #8 review finding on editor.rs:3271-3276.

Authority

The PR #8 review (CodeRabbit Major, data integrity); the repo's rule that a review finding is verified against current code before it is fixed.

Stopping condition

The tests exist, they fail on the old behaviour and pass on the new, and the fix is committed with its receipt.

Verification

cargo test -p app

Evidence and blockers

The finding is real and specific: CodeRabbit's Major on crates/app/src/editor.rs:3271-3276 reports that Pen-drawn points are folded into a Hotspot commit, because the plotted-draft state does not record which tool owns it. PR #8 is still open, and the campaign's P2.4 items "Track the originating tool in draft state", "Reset or explicitly convert drafts on tool changes" and "Add regression tests for Pen-to-Hotspot and reverse switching" are all unchecked.

No fix or regression test exists on any branch yet.

Blocker: none.

Ledger: docs/tasks/T27-23-draft-tool-ownership.md and docs/release/EXECUTION-BOARD.md row T27-23 (these land with PR #12).
Campaign: docs/planning/release-compaign/Cross-Platform Releas.txt.

Lenguaje dominante
Rust
Estrellas
11
Forks
1
Merge medio
9 h 48 min
PR fusionados (30 d)
13

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de aliasfoxkde/FireCraft

Todos los issues de aliasfoxkde/FireCraft

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.