s/cont.new/cont.run/g
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 5/5
- Tempo stimato
- Più di una settimana
- Idoneità per principianti
- 25/100
- Tipo di issue
- Funzionalità
- Chiarezza
- Abbastanza chiara
- Stato di attività
- Ferma
- Stack tecnologico
- wasm
- Ambito
- compilers
Direzione di ricerca
Start by reading the proposal's existing cont.new, resume, and resume_throw definitions, then trace the V8 compilation and decoding flow described in the issue, including the type and function sections. The work is complete when the design decision for replacing cont.new with cont.run is agreed and the coroutine-creation and never-suspending use cases are addressed.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
It turns out that implementing cont.new is not trivial in V8. The reasons have to do with how we want to 'interpret' suspensions and subsequent resumptions.
In normal flow, a resume always follows a suspend. From the pov of a coroutine, the suspend and subsequent 'recovery' on being resumed looks a lot like calling a function:
push a1
..
push ak
push K
suspend tag
local.set r1
..
local.set rm
It is our intention to reuse the existing machinery for function calling to make this pattern as performant as possible.
cont.new does not fall into this pattern, because, instead of the return values from the suspend being on the value stack, they form the arguments to the function itself.
However, when implementing resume, we do not know whether this is the first time a coroutine is being 'woken up' or is actually following a suspend. The code generated for resume must assume the latter.
This implies that we must generate additional code for each occurrence of cont.new just to handle this mismatch. In addition, since the argument to cont.new is a funcref, not a named function, we cannot modify the code of the function itself (e.g., by adding a preamble to the compiled function).
Generating these 'co-wrappers' is a non-trivial change to the compilation flow of V8. We have to decide how to manage the wrappers that we generate and we have to decide when to generate them. Generating them at the point of compiling cont.new requires that the entire compilation chain itself can be recursively reentered and also risks generating a lot of identical looking code. Generating them during decoding (e.g. after decoding the type section and before decoding/compiling the function section) has architectural implications (polluting the compilation pipeline somewhat egregiously).
From a dynamic computation pov, having these co-wrappers is almost equivalent having cont.new automatically entering the newly created coroutine and being immediately suspended.
IMO, a cleaner design that honors reasonable implementation strategies would be to not have cont.new, but to have cont.run; which would be specified as a variant of resume and resume_throw. This would also address an issue that I have raised before: of supporting the use case where coroutines are created but which never suspend.
- Lingua principale
- WebAssembly
- Stelle
- 216
- Fork
- 19
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di WebAssembly/stack-switching
-
Difficoltà 5/5 Più di una settimana Idoneità per principianti 35/100
WebAssembly/stack-switching#156 · 1 commento ·
-
Difficoltà 5/5 Più di una settimana Idoneità per principianti 35/100
WebAssembly/stack-switching#145 · 4 commenti ·
-
Difficoltà 5/5 Più di una settimana Idoneità per principianti 35/100
WebAssembly/stack-switching#144 · 4 commenti ·
-
JSPI integration Aperta
Difficoltà 5/5 Più di una settimana Idoneità per principianti 25/100
WebAssembly/stack-switching#131 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 45/100
WebAssembly/stack-switching#128 · 6 commenti ·
Tutte le issue di WebAssembly/stack-switching
Issue simili
-
`String.Parser.chompUntilEndOr` leaves the column one short when it runs to the end past a newline Aperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 82/100
-
enhancement PyCDE
Difficoltà 2/5 1-3 ore Idoneità per principianti 78/100
-
llvm:support
Difficoltà 2/5 1-3 ore Idoneità per principianti 76/100
llvm/llvm-project#226296 ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 75/100
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 88/100
abseil/abseil-cpp#2176 ·