Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

d2d1: please pick Wine 4ae80e26e5 (memory leak in every Direct2D path geometry)

Aperta
  • Qualcosa non va?
#372 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
2/5
Tempo stimato
1-3 ore
Idoneità per principianti
38/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
c, linux
Ambito
backend

Direzione di ricerca

Start in dlls/d2d1/geometry.c and inspect d2d_figure_cleanup(), which the issue identifies as leaving figure->vertex_types allocated. Compare the referenced upstream Wine commit 4ae80e26e5bd6bc30e0e7e7fe3b1a60895f896de with the Proton 11 Wine branches. Done means the backport frees the array and the supplied 300,000-geometry reproducer retains no growth from these arrays.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Proton version: 11.0-2e. The fix is also missing from the current proton_11.0, experimental_11.0 and bleeding-edge branches of ValveSoftware/wine (checked 2026-10-22).
Game: Microsoft Flight Simulator 2024 (2537590) with the Fenix A320 add-on, but it affects any program that uses ID2D1PathGeometry.

Problem

d2d_figure_cleanup() in dlls/d2d1/geometry.c never frees figure->vertex_types, so every path geometry figure leaks that array (about 52 bytes per simple geometry). Programs that rebuild path geometries every frame grow without bound. In MSFS 2024, the Fenix A320's FenixDisplay.exe grows by about 90 MB/min, and its cockpit displays get slower and slower during a flight.

Upstream Wine fixed this on 2026-06-28 in 4ae80e26e5bd6bc30e0e7e7fe3b1a60895f896de ("d2d1: Free the vertex types array in d2d_figure_cleanup", https://bugs.winehq.org/show_bug.cgi?id=59916). The fix is a one-line change and is in Wine 11.12 and later, but not in Wine 11.0, which Proton 11 is based on.

Minimal reproducer

No render target needed:

for (i = 0; i < 300000; ++i) {
    ID2D1Factory_CreatePathGeometry(factory, &g);
    ID2D1PathGeometry_Open(g, &s);
    ID2D1GeometrySink_BeginFigure(s, start, D2D1_FIGURE_BEGIN_FILLED);
    ID2D1GeometrySink_AddLines(s, pts, 4);
    ID2D1GeometrySink_EndFigure(s, D2D1_FIGURE_END_CLOSED);
    ID2D1GeometrySink_Close(s);
    ID2D1GeometrySink_Release(s);
    ID2D1PathGeometry_Release(g);
}

Working set after the loop: +15,360 kB with the current d2d1 (52.4 B per geometry), +0 kB with free(figure->vertex_types) added.

Request

Please pick 4ae80e26e5 into the Proton 11 Wine branches. The Fenix A320 Linux patch project already ships it as a backport (https://github.com/marselnenaj/fenix-a320-linux-patch/pull/10) and reports 0 retained bytes in a 300,000-geometry test on all four of its runners.

Note: I run MSFS through that project's Proton-based runner, not stock Proton, and measured with its d2d1.dll. d2d_figure_cleanup() in ValveSoftware/wine proton_11.0 is the same unfixed code (it frees original_bezier_controls, bezier_controls and vertices, but not vertex_types).

The analysis was done with the help of Claude (Anthropic's AI assistant). I reviewed the results and ran them on my own system.

Lingua principale
C
Stelle
2.1k
Fork
521
Nessuna PR unita negli ultimi 30g

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di ValveSoftware/wine

Tutte le issue di ValveSoftware/wine

Issue simili

Altre issue su C

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.