Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

d2d1: please pick Wine 4ae80e26e5 (memory leak in every Direct2D path geometry)

Abierto
  • ¿Algo no está bien?
#372 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
2/5
Tiempo estimado
1-3 horas
Aptitud para principiantes
38/100
Tipo de issue
Error
Claridad
Bien especificado
Estado de actividad
Activo
Stack tecnológico
c, linux
Área
backend

Línea de trabajo

Start in dlls/d2d1/geometry.c and inspect d2d_figure_cleanup(), which the issue identifies as leaving figure->vertex_types allocated. Compare the referenced upstream Wine commit 4ae80e26e5bd6bc30e0e7e7fe3b1a60895f896de with the Proton 11 Wine branches. Done means the backport frees the array and the supplied 300,000-geometry reproducer retains no growth from these arrays.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Proton version: 11.0-2e. The fix is also missing from the current proton_11.0, experimental_11.0 and bleeding-edge branches of ValveSoftware/wine (checked 2026-10-22).
Game: Microsoft Flight Simulator 2024 (2537590) with the Fenix A320 add-on, but it affects any program that uses ID2D1PathGeometry.

Problem

d2d_figure_cleanup() in dlls/d2d1/geometry.c never frees figure->vertex_types, so every path geometry figure leaks that array (about 52 bytes per simple geometry). Programs that rebuild path geometries every frame grow without bound. In MSFS 2024, the Fenix A320's FenixDisplay.exe grows by about 90 MB/min, and its cockpit displays get slower and slower during a flight.

Upstream Wine fixed this on 2026-06-28 in 4ae80e26e5bd6bc30e0e7e7fe3b1a60895f896de ("d2d1: Free the vertex types array in d2d_figure_cleanup", https://bugs.winehq.org/show_bug.cgi?id=59916). The fix is a one-line change and is in Wine 11.12 and later, but not in Wine 11.0, which Proton 11 is based on.

Minimal reproducer

No render target needed:

for (i = 0; i < 300000; ++i) {
    ID2D1Factory_CreatePathGeometry(factory, &g);
    ID2D1PathGeometry_Open(g, &s);
    ID2D1GeometrySink_BeginFigure(s, start, D2D1_FIGURE_BEGIN_FILLED);
    ID2D1GeometrySink_AddLines(s, pts, 4);
    ID2D1GeometrySink_EndFigure(s, D2D1_FIGURE_END_CLOSED);
    ID2D1GeometrySink_Close(s);
    ID2D1GeometrySink_Release(s);
    ID2D1PathGeometry_Release(g);
}

Working set after the loop: +15,360 kB with the current d2d1 (52.4 B per geometry), +0 kB with free(figure->vertex_types) added.

Request

Please pick 4ae80e26e5 into the Proton 11 Wine branches. The Fenix A320 Linux patch project already ships it as a backport (https://github.com/marselnenaj/fenix-a320-linux-patch/pull/10) and reports 0 retained bytes in a 300,000-geometry test on all four of its runners.

Note: I run MSFS through that project's Proton-based runner, not stock Proton, and measured with its d2d1.dll. d2d_figure_cleanup() in ValveSoftware/wine proton_11.0 is the same unfixed code (it frees original_bezier_controls, bezier_controls and vertices, but not vertex_types).

The analysis was done with the help of Claude (Anthropic's AI assistant). I reviewed the results and ran them on my own system.

Lenguaje dominante
C
Estrellas
2.1k
Forks
521
Sin PR fusionados en 30 d

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de ValveSoftware/wine

Todos los issues de ValveSoftware/wine

Issues similares

Más issues de C

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.