Layout never settles when the vertical scroll bar decides whether content overflows (re-layout on every frame)
Nessuno ha ancora preso questa issue.
Valutazione
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Idoneità per principianti
- 53/100
Direzione di ricerca
Start by running the supplied minimal reproduction with app.run_test(size=(18, 5)); it instruments Screen._refresh_layout and shows the alternating scrollbar and widget-height states. Read Screen._refresh_layout and the layout/scrollbar behavior it invokes to understand why the screen keeps relaying out. Done means the layout settles for this case, idle layout counts stop increasing, and pilot.pause() can reach idle.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Descrizione
Hi! I hit this while writing generated tests against Textual's widgets. Some small layouts never settle. Showing the screen's vertical scroll bar takes 2 cells, which makes a percentage-width widget too narrow to have any text, so it's 0 rows tall, so nothing overflows, so the bar goes, and then the text wraps again and overflows. Textual re-lays the screen out on every update tick, indefinitely, and the widget alternates between the two states. This looks like the same kind of loop as #4141, which #4315 fixed, but this case still loops on main.
import asyncio
import time
import textual
from textual.app import App, ComposeResult
from textual.screen import Screen
from textual.widgets import Static
class FlipApp(App):
CSS = """
Static { width: 50%; padding: 0 4; }
"""
def compose(self) -> ComposeResult:
yield Static("abcdef")
async def main() -> None:
layouts = 0
states = []
original = Screen._refresh_layout
def counting_refresh_layout(self, *args, **kwargs):
nonlocal layouts
layouts += 1
result = original(self, *args, **kwargs)
if self.is_attached and self.query(Static):
states.append((self.show_vertical_scrollbar, self.query_one(Static).size.height))
return result
Screen._refresh_layout = counting_refresh_layout
app = FlipApp()
async with app.run_test(size=(18, 5)) as pilot:
await pilot.pause(0.2)
states.clear()
layouts = 0
await asyncio.sleep(1)
in_one_second = layouts
start = time.monotonic()
await pilot.pause()
pause_took = time.monotonic() - start
print(f"Textual {textual.__version__}")
print("(screen scroll bar shown, Static height) after the first 6 layouts:", states[:6])
print("screen layouts in one idle second:", in_one_second)
print(f"pilot.pause() took {pause_took:.2f} s")
asyncio.run(main())
Output on main (5e5b7ef), Python 3.13, macOS:
Textual 8.2.8
(screen scroll bar shown, Static height) after the first 6 layouts: [(False, 0), (True, 6), (False, 0), (True, 6), (False, 0), (True, 6)]
screen layouts in one idle second: 57
pilot.pause() took 1.02 s
On 8.2.7 it's the same: the same alternation, 51 layouts in the idle second. pilot.pause() took 0.12 s in that run, so the time it takes varies.
What users see:
- the widget flickers between two layouts, and the app uses CPU while idle;
- which layout a given frame shows depends on the clock;
- in tests,
pilot.pause()(throughwait_for_idle) can wait up to itsmax_sleepof 1 second, because the app is never idle.
I expected the layout to settle in one of the two states, for example by keeping the scroll bar once it has been shown for a layout that would otherwise loop. Adding Screen { scrollbar-gutter: stable; } to the CSS above avoids it: 0 layouts in the idle second, and pilot.pause() takes 0.02 s. I don't know the layout code well enough to suggest where to detect the loop, so I'm reporting it with the repro rather than a fix.
- Lingua principale
- Python
- Stelle
- 37.7k
- Fork
- 1.5k
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Preparare l'ambiente
- Nessun Dockerfile né file Docker Compose
- Ha un modello di pull request
- Leggi la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Altre issue di Textualize/textual
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
Textualize/textual#6790 · 2 commenti ·
-
Markdown table of contents: the node added for a skipped heading level shows the wrong numeralAperta
Difficoltà 2/5 1-3 ore Idoneità per principianti 80/100
Textualize/textual#6789 · 1 commento ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
Textualize/textual#6787 · 1 commento ·
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
Textualize/textual#6782 · 1 commento ·
-
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 85/100
Textualize/textual#6778 · 1 commento ·
Tutte le issue di Textualize/textual
Issue simili
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 72/100
mohanraj00/entelos#200 ·
I maintainer di solito rispondono entro 1 giorno
-
Dead url in mise.tomlAperta
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 68/100
-
sweep
Difficoltà 2/5 1-3 ore Idoneità per principianti 85/100
bketelsen/truenas-mcp#77 ·
I maintainer di solito rispondono entro 1 giorno
-
Console writes URL credentials to the local log, though AGENTS.md says secrets never reach diskAperta
Difficoltà 1/5 Meno di un'ora Idoneità per principianti 86/100
sandbox-quantum/switch#2163 ·
I maintainer di solito rispondono entro 1 giorno
-
Difficoltà 2/5 1-3 ore Idoneità per principianti 74/100
openedx/xblock-lti-consumer#765 ·
I maintainer di solito rispondono entro 1 giorno