Layout never settles when the vertical scroll bar decides whether content overflows (re-layout on every frame)

Abierto
#6,785 3 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
4/5
Tiempo estimado
3-5 días
Aptitud para principiantes
53/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
python
Área
frontend

Línea de trabajo

Start by running the supplied minimal reproduction with app.run_test(size=(18, 5)); it instruments Screen._refresh_layout and shows the alternating scrollbar and widget-height states. Read Screen._refresh_layout and the layout/scrollbar behavior it invokes to understand why the screen keeps relaying out. Done means the layout settles for this case, idle layout counts stop increasing, and pilot.pause() can reach idle.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Hi! I hit this while writing generated tests against Textual's widgets. Some small layouts never settle. Showing the screen's vertical scroll bar takes 2 cells, which makes a percentage-width widget too narrow to have any text, so it's 0 rows tall, so nothing overflows, so the bar goes, and then the text wraps again and overflows. Textual re-lays the screen out on every update tick, indefinitely, and the widget alternates between the two states. This looks like the same kind of loop as #4141, which #4315 fixed, but this case still loops on main.

import asyncio
import time

import textual
from textual.app import App, ComposeResult
from textual.screen import Screen
from textual.widgets import Static

class FlipApp(App):
    CSS = """
    Static { width: 50%; padding: 0 4; }
    """

    def compose(self) -> ComposeResult:
        yield Static("abcdef")

async def main() -> None:
    layouts = 0
    states = []
    original = Screen._refresh_layout

    def counting_refresh_layout(self, *args, **kwargs):
        nonlocal layouts
        layouts += 1
        result = original(self, *args, **kwargs)
        if self.is_attached and self.query(Static):
            states.append((self.show_vertical_scrollbar, self.query_one(Static).size.height))
        return result

    Screen._refresh_layout = counting_refresh_layout

    app = FlipApp()
    async with app.run_test(size=(18, 5)) as pilot:
        await pilot.pause(0.2)
        states.clear()
        layouts = 0
        await asyncio.sleep(1)
        in_one_second = layouts
        start = time.monotonic()
        await pilot.pause()
        pause_took = time.monotonic() - start
    print(f"Textual {textual.__version__}")
    print("(screen scroll bar shown, Static height) after the first 6 layouts:", states[:6])
    print("screen layouts in one idle second:", in_one_second)
    print(f"pilot.pause() took {pause_took:.2f} s")

asyncio.run(main())

Output on main (5e5b7ef), Python 3.13, macOS:

Textual 8.2.8
(screen scroll bar shown, Static height) after the first 6 layouts: [(False, 0), (True, 6), (False, 0), (True, 6), (False, 0), (True, 6)]
screen layouts in one idle second: 57
pilot.pause() took 1.02 s

On 8.2.7 it's the same: the same alternation, 51 layouts in the idle second. pilot.pause() took 0.12 s in that run, so the time it takes varies.

What users see:

  • the widget flickers between two layouts, and the app uses CPU while idle;
  • which layout a given frame shows depends on the clock;
  • in tests, pilot.pause() (through wait_for_idle) can wait up to its max_sleep of 1 second, because the app is never idle.

I expected the layout to settle in one of the two states, for example by keeping the scroll bar once it has been shown for a layout that would otherwise loop. Adding Screen { scrollbar-gutter: stable; } to the CSS above avoids it: 0 layouts in the idle second, and pilot.pause() takes 0.02 s. I don't know the layout code well enough to suggest where to detect the loop, so I'm reporting it with the repro rather than a fix.

Lenguaje dominante
Python
Estrellas
37.7k
Forks
1.5k
Métricas de merge de PR
Sin PR fusionados en 30 d

Preparar el entorno

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Textualize/textual

Todos los issues de Textualize/textual

Issues similares

Más issues de Python

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.