daemon inputs: after a hang replaced the only context, the next check through the daemon reuses nothing (#133)

Aperta
#175 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
javascript
Ambito
testing

Direzione di ricerca

Read the README's reuse contract, R13, and the daemon and warm-read logic in check.mjs around warmReads and globalKey. Compare the fixed-seed e2e unit's reach on #133 with main, then add an oracle law for reuse of the unedited file's runs after a hang replaces the only context. The issue leaves the cause unconfirmed and describes alternative fixes; done means the law captures the regression and the correct check still matches the cold run.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Summary

On #133 (since at least 9bb7c74a, and at 5fc4b9a4), the fixed-seed e2e unit a check through the daemon that works past the bound reuses no unit in its test-edit check through the daemon. On main (97a4e7a8 and 30928ee8), the same check reuses file b's runs. It reaches incremental check reused evidence and incremental check reused some evidence and recomputed some.

This is a loss of reuse, not of correctness: the check still equals the cold run. The campaign does not lose these states, because 34 and 24 other units reach them. But the unit's own reach moved, and no law requires partial reuse after an edit, so the oracle passes.

Trace

  • #133 at 5fc4b9a4: CI run 44436324847, job 135266004465 (fixed seed 2/5). The unit's reach has a check through the daemon worked past its CLI's bound, an edit that changed the cold result after a hang replaced the only context and edit test changed the cold result, and neither reuse state.
  • Main 30928ee8: run 44435834785, job 135264344204. Its reach also has both reuse states.

Likely cause (plausible, not confirmed)

In this history a slow copy is cut, and a new context warms in place of the cut one. A warm records its reads as global inputs (warmReads, check.mjs), which become part of the unit identity (globalKey). If the replacement warm reads a file or variable that the first warm did not, then the next check's globalKey differs from the one the earlier units were stored under, and every unit misses once.

Possible fixes:

  • A warm in place of a cut context records new reads as hook reads, like a read that arrives after its warm ended.
  • Or the global key covers only the reads of a session's first warm.

Either needs a law that the oracle can judge. One option is to require reuse of the unedited file's runs in the check after a hang replaced the only context, which is a state the grammar already reaches.

Authority

The README's reuse contract and R13 (the daemon is the default). M-30 is met (I8 holds), so this is a speed regression, which belongs to the maintainer's cost rules (P12 / R7).

This issue was written by Isaac.

Lingua principale
JavaScript
Stelle
5
Fork
1
Merge medio
11h 18m
PR unite (30g)
66

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di TanStack/oracles

Tutte le issue di TanStack/oracles

Issue simili

Altre issue su JavaScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.