daemon inputs: after a hang replaced the only context, the next check through the daemon reuses nothing (#133)

Abierto
#175 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
javascript
Área
testing

Línea de trabajo

Read the README's reuse contract, R13, and the daemon and warm-read logic in check.mjs around warmReads and globalKey. Compare the fixed-seed e2e unit's reach on #133 with main, then add an oracle law for reuse of the unedited file's runs after a hang replaces the only context. The issue leaves the cause unconfirmed and describes alternative fixes; done means the law captures the regression and the correct check still matches the cold run.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

Summary

On #133 (since at least 9bb7c74a, and at 5fc4b9a4), the fixed-seed e2e unit a check through the daemon that works past the bound reuses no unit in its test-edit check through the daemon. On main (97a4e7a8 and 30928ee8), the same check reuses file b's runs. It reaches incremental check reused evidence and incremental check reused some evidence and recomputed some.

This is a loss of reuse, not of correctness: the check still equals the cold run. The campaign does not lose these states, because 34 and 24 other units reach them. But the unit's own reach moved, and no law requires partial reuse after an edit, so the oracle passes.

Trace

  • #133 at 5fc4b9a4: CI run 44436324847, job 135266004465 (fixed seed 2/5). The unit's reach has a check through the daemon worked past its CLI's bound, an edit that changed the cold result after a hang replaced the only context and edit test changed the cold result, and neither reuse state.
  • Main 30928ee8: run 44435834785, job 135264344204. Its reach also has both reuse states.

Likely cause (plausible, not confirmed)

In this history a slow copy is cut, and a new context warms in place of the cut one. A warm records its reads as global inputs (warmReads, check.mjs), which become part of the unit identity (globalKey). If the replacement warm reads a file or variable that the first warm did not, then the next check's globalKey differs from the one the earlier units were stored under, and every unit misses once.

Possible fixes:

  • A warm in place of a cut context records new reads as hook reads, like a read that arrives after its warm ended.
  • Or the global key covers only the reads of a session's first warm.

Either needs a law that the oracle can judge. One option is to require reuse of the unedited file's runs in the check after a hang replaced the only context, which is a state the grammar already reaches.

Authority

The README's reuse contract and R13 (the daemon is the default). M-30 is met (I8 holds), so this is a speed regression, which belongs to the maintainer's cost rules (P12 / R7).

This issue was written by Isaac.

Lenguaje dominante
JavaScript
Estrellas
5
Forks
1
Merge medio
11 h 18 min
PR fusionados (30 d)
66

Preparar el entorno

Este proyecto no incluye contenedor de desarrollo, Dockerfile ni guía de contribución, así que la configuración corre por tu cuenta: empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de TanStack/oracles

Todos los issues de TanStack/oracles

Issues similares

Más issues de JavaScript

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.