Flaky capture smoke: the resumed segment is sometimes missing from the paused recording

Aperta
#331 3 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
55/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
typescript
Ambito
backend, testing

Direzione di ricerca

Start with the Windows capture smoke in src/__tests__/captureSmoke.test.ts:93-130, then trace runStop to joinSegments in src/utils/lifecycle.ts and the resume and finalization paths in src/utils/pause.ts and src/utils/recorder.ts. Run RUN_CAPTURE_SMOKE=1 npx vitest run src/__tests__/captureSmoke.test.ts on Windows. Done means failures report segment count, part durations, and join errors, and the root cause is identified with the resumed segment retained or the test waiting until it has frames.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

ci priority: medium testing

Summary

The Windows CI capture smoke "leaves a paused stretch out of the file and the markers (#200)" fails intermittently, including its retry, and a red run blocks the release. In the failures the stopped recording holds only the first segment, or has a gap over 1 s, so the resumed segment is missing or late in the join.

Where

  • src/__tests__/captureSmoke.test.ts:93-130 (start, 2 s, pause, 3 s, resume, 2 s, stop)
  • Join path: src/utils/lifecycle.ts (runStop -> joinSegments), src/utils/pause.ts (finishSegments), src/utils/recorder.ts (resume spawn)

Details

Seen on build-and-test (windows-latest, 22) and (windows-latest, 24):

AssertionError: 102 frames over 3.354583s, first segment 3.353s: expected 3.354583 to be greater than 4.353
AssertionError: widest gap 1.367973s; 100 frames over 9.415311s, first segment 3.479s: expected 1.367973 to be less than 1

In the first kind the output is exactly the first segment: the resumed segment contributed no frames, although the test records for 2 s after resume_recording returns. Commits 8a4fad6, e25cc00 and 265975b failed this way; neighbouring commits passed. It did not reproduce locally (3 runs alone and one under the full suite, Windows 11).

Impact

Intermittent red CI on main; per the release flow a red run skips the npm publish. If the resumed segment is really being lost, users lose footage after a pause.

Suggested fix

  1. Have the test print the stop result's segments (count and any join error) and the per-part durations, so the next failure shows whether the second part is empty, missing or dropped by the join.
  2. Check whether a resumed gdigrab capture that is stopped soon after starting can finalize with zero frames on a slow runner, and whether joinSegments then silently skips it.

Acceptance criteria

  • A failure reports the segment count, part durations and any join error
  • Root cause identified; either the join keeps the resumed part or the test waits for it to have frames

Getting started

  • Relevant files: src/__tests__/captureSmoke.test.ts, src/utils/lifecycle.ts, src/utils/pause.ts, src/utils/recorder.ts
  • How to run tests: RUN_CAPTURE_SMOKE=1 npx vitest run src/__tests__/captureSmoke.test.ts on Windows

Related: #200


Filed by repo-audit/fix-issues at a6cfc9b. Severity: medium. Effort: M. audit-key: testing|src/__tests__/captureSmoke.test.ts|paused-stretch-missing-resume-segment

Lingua principale
TypeScript
Stelle
1
Fork
4
Merge medio
14h 8m
PR unite (30g)
48

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di TMHSDigital/screencast-mcp

Tutte le issue di TMHSDigital/screencast-mcp

Issue simili

Altre issue su TypeScript

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.