Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

GitSync: an Ignore pattern added after the first import leaves the imported nodes in place, and on a one-way Space nobody can remove them

Chiusa
  • Qualcosa non va?
#7,611 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Una pull request collegata è già stata integrata.

  • #7641 di @rbuergi — integrata

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
35/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
csharp
Ambito
authorization, backend

Direzione di ricerca

Start with src/MeshWeaver.Graph/StaticRepoImporter.cs, src/MeshWeaver.Mesh.Contract/IStaticRepoSource.cs, and src/MeshWeaver.Mesh.Contract/Services/AccessAssignmentGuard.cs; review the behavior introduced by #1326 and #5140. Determine how to identify nodes imported by this source and choose among the three proposed outcomes. Done means ignored imported nodes can be handled safely without removing mesh-minted nodes, with the selected behavior covered and documented as appropriate.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement feature:gitsync-ownership feature:node-delete sev:M

Why this repository

The sync source (src/MeshWeaver.GitSync), the import prune (src/MeshWeaver.Graph/StaticRepoImporter.cs,
src/MeshWeaver.Mesh.Contract/IStaticRepoSource.cs) and the system-owned write cap
(src/MeshWeaver.Mesh.Contract/Services/AccessAssignmentGuard.cs) are platform code. Prior art checked:
#1326 (closed) made the prune skip ignored paths; #5140 (closed) made the write cap cover a Space's own
Admin; #1120 (closed) keeps the last Admin grant; #3589 (closed) covers files the repository dropped, not
files the Ignore list excludes. No open issue covers the combination.

What happens

Measured on an enterprise client's control instance, build 3.1.12009 (commit e4f379d), on 2026-10-29.

  1. A Space is created by hand and {space}/_GitSync is configured one-way (Two-way off) on a
    subdirectory that holds four deployment records. "Update to latest" imports all four. Three of them
    describe another estate.
  2. The administrator adds the three file names to the Ignore list, as the field offers ("Ignore
    patterns (gitignore-style, relative to the Space root)").
  3. The three imported nodes stay. The prune skips ignored paths by design since #1326
    (IStaticRepoSource.cs: "the prune MUST skip it"), so "Update to latest" and "Re-import" leave them
    untouched.
  4. Nobody can remove them. The Space is system-owned, so the write cap turns every user's permission on
    content paths to read-only, the Admin's included (#5140). The Delete entry is filtered out of the node
    menu. Only the System identity may write, and no operation asks it to remove the nodes.
  5. The nodes are neither synced nor owned: a projection the repository no longer controls, frozen at
    the last imported version. In the measured case the Hosting control plane treated them as fleet
    members: a record-change Reconcile dispatched against a repository the instance's App has no rights
    on (404, terminal), and the fleet watch wrote a row for a record whose host is the placeholder
    "TODO".

Workaround that worked

Tick Two-way on the sync configuration (the Space stops being system-owned and the cap lifts), delete
each node through /{node}/Delete, untick Two-way. It works only because the retraction sweep keeps the
last Admin grant (#1120). It is undocumented, and while Two-way is on, every Admin may edit the records
the repository owns.

Expected

One of the following, for the maintainers to choose:

  1. An "Update to latest" after the Ignore list changed removes the nodes this source imported under the
    now-ignored paths, and keeps nodes the mesh minted under the same pattern (the Release/ case of
    #1326). This needs the importer to tell its own imports from mesh-minted nodes; I did not establish
    whether the stored nodes carry that fact.
  2. The GitHub Sync settings tab offers an explicit action, run as System, that lists the imported nodes
    the Ignore list now excludes and removes them after confirmation.
  3. At least, saving an Ignore pattern that matches already-imported nodes warns that they stay, and
    Doc/Architecture/GitHubSync says so.

Not established

  1. Whether /{node}/Delete is refused for the Space's Admin while the Space is system-owned. The menu
    entry was absent; the URL was tried only after Two-way was on. (The node type in question draws its
    own landing page without the header menu, so the absent entry alone proves nothing.)
  2. Whether the retraction sweep ran on the measured Space. The Admin grant was effective once Two-way
    was on, which fits "last Admin kept".
Lingua principale
C#
Stelle
12
Fork
5
Merge medio
5h 28m
PR unite (30g)
976

Preparare l'ambiente

  • Nessun Dockerfile né file Docker Compose
  • Ha un modello di pull request
  • Nessuna guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Systemorph/MeshWeaver

Tutte le issue di Systemorph/MeshWeaver

Issue simili

Altre issue su C#

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.