Hacktoberfest 2026: los issues que los mantenedores marcaron para octubre, abiertos y aptos para principiantes. Explorar issues de Hacktoberfest

GitSync: an Ignore pattern added after the first import leaves the imported nodes in place, and on a one-way Space nobody can remove them

Abierto
  • ¿Algo no está bien?
#7,611 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

@rbuergi ya está trabajando en esto.

Desde el 30/10/2026.

  • #7641 de @rbuergi — abierto

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
35/100
Tipo de issue
Error
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
csharp
Área
authorization, backend

Línea de trabajo

Start with src/MeshWeaver.Graph/StaticRepoImporter.cs, src/MeshWeaver.Mesh.Contract/IStaticRepoSource.cs, and src/MeshWeaver.Mesh.Contract/Services/AccessAssignmentGuard.cs; review the behavior introduced by #1326 and #5140. Determine how to identify nodes imported by this source and choose among the three proposed outcomes. Done means ignored imported nodes can be handled safely without removing mesh-minted nodes, with the selected behavior covered and documented as appropriate.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

enhancement feature:gitsync-ownership feature:node-delete sev:M

Why this repository

The sync source (src/MeshWeaver.GitSync), the import prune (src/MeshWeaver.Graph/StaticRepoImporter.cs,
src/MeshWeaver.Mesh.Contract/IStaticRepoSource.cs) and the system-owned write cap
(src/MeshWeaver.Mesh.Contract/Services/AccessAssignmentGuard.cs) are platform code. Prior art checked:
#1326 (closed) made the prune skip ignored paths; #5140 (closed) made the write cap cover a Space's own
Admin; #1120 (closed) keeps the last Admin grant; #3589 (closed) covers files the repository dropped, not
files the Ignore list excludes. No open issue covers the combination.

What happens

Measured on an enterprise client's control instance, build 3.1.12009 (commit e4f379d), on 2026-10-29.

  1. A Space is created by hand and {space}/_GitSync is configured one-way (Two-way off) on a
    subdirectory that holds four deployment records. "Update to latest" imports all four. Three of them
    describe another estate.
  2. The administrator adds the three file names to the Ignore list, as the field offers ("Ignore
    patterns (gitignore-style, relative to the Space root)").
  3. The three imported nodes stay. The prune skips ignored paths by design since #1326
    (IStaticRepoSource.cs: "the prune MUST skip it"), so "Update to latest" and "Re-import" leave them
    untouched.
  4. Nobody can remove them. The Space is system-owned, so the write cap turns every user's permission on
    content paths to read-only, the Admin's included (#5140). The Delete entry is filtered out of the node
    menu. Only the System identity may write, and no operation asks it to remove the nodes.
  5. The nodes are neither synced nor owned: a projection the repository no longer controls, frozen at
    the last imported version. In the measured case the Hosting control plane treated them as fleet
    members: a record-change Reconcile dispatched against a repository the instance's App has no rights
    on (404, terminal), and the fleet watch wrote a row for a record whose host is the placeholder
    "TODO".

Workaround that worked

Tick Two-way on the sync configuration (the Space stops being system-owned and the cap lifts), delete
each node through /{node}/Delete, untick Two-way. It works only because the retraction sweep keeps the
last Admin grant (#1120). It is undocumented, and while Two-way is on, every Admin may edit the records
the repository owns.

Expected

One of the following, for the maintainers to choose:

  1. An "Update to latest" after the Ignore list changed removes the nodes this source imported under the
    now-ignored paths, and keeps nodes the mesh minted under the same pattern (the Release/ case of
    #1326). This needs the importer to tell its own imports from mesh-minted nodes; I did not establish
    whether the stored nodes carry that fact.
  2. The GitHub Sync settings tab offers an explicit action, run as System, that lists the imported nodes
    the Ignore list now excludes and removes them after confirmation.
  3. At least, saving an Ignore pattern that matches already-imported nodes warns that they stay, and
    Doc/Architecture/GitHubSync says so.

Not established

  1. Whether /{node}/Delete is refused for the Space's Admin while the Space is system-owned. The menu
    entry was absent; the URL was tried only after Two-way was on. (The node type in question draws its
    own landing page without the header menu, so the absent entry alone proves nothing.)
  2. Whether the retraction sweep ran on the measured Space. The Admin grant was effective once Two-way
    was on, which fits "last Admin kept".
Lenguaje dominante
C#
Estrellas
12
Forks
5
Merge medio
5 h 37 min
PR fusionados (30 d)
959

Preparar el entorno

  • Sin Dockerfile ni archivo de Docker Compose
  • Tiene una plantilla de pull request
  • Sin guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Systemorph/MeshWeaver

Todos los issues de Systemorph/MeshWeaver

Issues similares

Más issues de C#

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.