Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

WaveformView (geometry mode): Alt + wheel scales x around probe x = 0, so snippets shift instead of widening on channels far from x = 0

Aperta
  • Qualcosa non va?
#286 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
68/100
Tipo di issue
Bug
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
python
Ambito
desktop, frontend

Direzione di ricerca

Start in waveformview.py at the initialization around line 78 and the geometry drawing sites around lines 468, 587, 632, 1087, 1239, and 1314; compare the Qt and Panel paths, including the Panel factor update around line 1049. Check existing waveform-view tests and reproduce with a unit on a contact far from x = 0. Done when Alt + wheel widens snippets around their contact positions across shanks without shifting them out of view.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

Description

In the WaveformView in geometry mode, Alt + mouse wheel (widen/narrow x axis) multiplies the absolute x coordinates of the snippets by factor_x. Each snippet is built around its contact position:

waveformview.py, line 78

self.xvect[chan_ind, :] = np.linspace(x - espx, x + espx, num=width)
and is then drawn as:

waveformview.py, line 468 (also lines 587, 632, 1087, 1239, 1314)

xvectors = self.xvect[common_channel_indexes, :] * self.factor_x
So the scaling happens around x = 0 of the probe, not around each contact. For units on contacts near x = 0 the snippet widens as expected. For units on contacts far from x = 0, each wheel step mostly translates the snippet sideways (by about 30% of its x position, since factor_x changes by a factor of 1.3). Because the refresh keeps the view range (keep_range=True), the waveform appears to move rather than widen and soon leaves the view.

This is very visible on multi-shank probes. With a Neuropixels 2.0 4-shank probe (shanks about 250 µm apart), widening works on shank 0 and is unusable on shanks 1–3.

To reproduce:

Open a SortingAnalyzer from a multi-shank probe (or any probe with contacts at large x).
In WaveformView (geometry mode), select a unit on a contact far from x = 0.
Alt + mouse wheel: the snippet slides horizontally instead of widening in place.
Expected: the snippet widens around its own contact position.

Possible fix: scale around each contact's x position, e.g. keep the contact x per channel and use

xvectors = xcenter[:, None] + (self.xvect[common_channel_indexes, :] - xcenter[:, None]) * self.factor_x
where xcenter holds the contact x positions of common_channel_indexes. The same applies to the other places where self.xvect * self.factor_x is used, including the Panel backend (factor_x updated at line 1049).

Environment: spikeinterface-gui 0.13.1 (same code on current main), spikeinterface 0.104.8, desktop (Qt / PySide6), Windows 10, Python 3.10.

Lingua principale
Python
Stelle
71
Fork
23
Merge medio
4g 4h
PR unite (30g)
5

Preparare l'ambiente

Questo progetto non fornisce container di sviluppo, Dockerfile né guida per i contributori, quindi l'ambiente è a tuo carico: parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di SpikeInterface/spikeinterface-gui

Tutte le issue di SpikeInterface/spikeinterface-gui

Issue simili

Altre issue su Python

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.