Merging a PR on GitHub lands the whole instance, across every repo it touched

Aperta
  • Qualcosa non va?
#340 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
5/5
Tempo stimato
Più di una settimana
Idoneità per principianti
25/100
Tipo di issue
Funzionalità
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
github, rust
Ambito
devtools

Direzione di ricerca

Start by reading the webhook behavior described in the issue and the handling added for #339, then trace how instance branches are identified and exported to GitHub targets. The proposal requires remote GitHub write credentials, permissions across trackers, and a clean merge check on both PRs. Done means merging either PR lands the instance across all touched trackers while preventing conflicts from leaving a partial merge; the issue gives no file or test paths.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

An instance's work can span trackers exported to different GitHub repos, for example root to Spheroman/newgit and t3code to Spheroman/t3code. One git push opens a branch on each, but GitHub can't merge two repos' PRs together. As of #339, the webhook refuses a PR whose instance also changed a withheld tracker, and logs that newgit merge <instance> is needed.

Proposal

Merging either PR lands the whole instance:

  1. The webhook sees the merged PR, and the branch name identifies the instance.
  2. newgit.dev lands the instance's own root commits, so its pins come along and every tracker moves together. Today the withheld pins come from the first parent.
  3. newgit.dev exports to every target the work touched.
  4. The other PR's commits are now in its base branch, so GitHub marks it merged.

What it needs

  • GitHub write access for newgit.dev. Today only a developer's machine pushes to GitHub. This needs a GitHub App or a token with write access to each target, stored on the remote.
  • Permissions: whoever merged must maintain every tracker the instance touches.
  • Conflicts: by the time GitHub reports the merge, one PR has already landed. A required status check, posted by newgit.dev on both PRs and saying whether the instance merges cleanly, can block the merge button in advance.

Why not a GitHub Action

An Action that runs gh pr merge on the sibling PR makes two merges, not one: if the second conflicts, the first has already landed. It also needs a cross-repo write token, and newgit would still see two unrelated merges.

Scope

After 0.9.0. The newgit.dev forge milestones make a PR span every tracker natively, so weigh this against how soon those land.

🤖 Generated with Claude Code

Lingua principale
Rust
Stelle
0
Fork
0
Merge medio
8h 1m
PR unite (30g)
129

Preparare l'ambiente

Non abbiamo ancora controllato i file di configurazione di questo progetto. Parti dal suo README e consulta la nostra guida al primo contributo per i passaggi generali.

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Spheroman/newgit

Tutte le issue di Spheroman/newgit

Issue simili

Altre issue su Rust

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.