Merging a PR on GitHub lands the whole instance, across every repo it touched

Abierto
  • ¿Algo no está bien?
#340 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Los mantenedores suelen responder en 1 día

Nadie ha tomado este issue todavía.

Evaluación

Dificultad
5/5
Tiempo estimado
Más de una semana
Aptitud para principiantes
25/100
Tipo de issue
Nueva funcionalidad
Claridad
Bastante claro
Estado de actividad
Activo
Stack tecnológico
github, rust
Área
devtools

Línea de trabajo

Start by reading the webhook behavior described in the issue and the handling added for #339, then trace how instance branches are identified and exported to GitHub targets. The proposal requires remote GitHub write credentials, permissions across trackers, and a clean merge check on both PRs. Done means merging either PR lands the instance across all touched trackers while preventing conflicts from leaving a partial merge; the issue gives no file or test paths.

Escrito por el modelo de indexación a partir del texto del issue.

Descripción

An instance's work can span trackers exported to different GitHub repos, for example root to Spheroman/newgit and t3code to Spheroman/t3code. One git push opens a branch on each, but GitHub can't merge two repos' PRs together. As of #339, the webhook refuses a PR whose instance also changed a withheld tracker, and logs that newgit merge <instance> is needed.

Proposal

Merging either PR lands the whole instance:

  1. The webhook sees the merged PR, and the branch name identifies the instance.
  2. newgit.dev lands the instance's own root commits, so its pins come along and every tracker moves together. Today the withheld pins come from the first parent.
  3. newgit.dev exports to every target the work touched.
  4. The other PR's commits are now in its base branch, so GitHub marks it merged.

What it needs

  • GitHub write access for newgit.dev. Today only a developer's machine pushes to GitHub. This needs a GitHub App or a token with write access to each target, stored on the remote.
  • Permissions: whoever merged must maintain every tracker the instance touches.
  • Conflicts: by the time GitHub reports the merge, one PR has already landed. A required status check, posted by newgit.dev on both PRs and saying whether the instance merges cleanly, can block the merge button in advance.

Why not a GitHub Action

An Action that runs gh pr merge on the sibling PR makes two merges, not one: if the second conflicts, the first has already landed. It also needs a cross-repo write token, and newgit would still see two unrelated merges.

Scope

After 0.9.0. The newgit.dev forge milestones make a PR span every tracker natively, so weigh this against how soon those land.

🤖 Generated with Claude Code

Lenguaje dominante
Rust
Estrellas
0
Forks
0
Merge medio
7 h 27 min
PR fusionados (30 d)
140

Preparar el entorno

Aún no hemos revisado los archivos de configuración de este proyecto. Empieza por su README y consulta nuestra guía para la primera contribución para los pasos generales.

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Más de Spheroman/newgit

Todos los issues de Spheroman/newgit

Issues similares

Más issues de Rust

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.