Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Remove controls with no outcome: the receipt's Show cue, and Change while the panel editor is recording

Aperta
  • Qualcosa non va?
#336 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
64/100
Tipo di issue
Refactoring
Chiarezza
Specificata chiaramente
Stato di attività
Attiva
Stack tecnologico
macos, swift
Ambito
desktop

Direzione di ricerca

Start at the Show cue button in WorkbenchHome.swift:537 and its handler in WorkbenchQuickPanel.swift:102, then trace ClipboardReceipt.swift:140-147 and CapturePanel.swift:1194-1230 to see what the button replays. Remove the button and its parameter at all three call sites, plus the gallery action, registry entry and revealHUD. For Change, the leading slot in WorkbenchQuickPanel.swift:181 should show Cancel while QuickPanelLifecycle.swift:18-21 reports recording. Done when the build, --check-feedback and check-surfaces.py pass, grep finds no leftovers, and both states render as described.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

enhancement

Outcome: two controls that do nothing useful go away.

1. Show cue
  • Problem: every copied dictation offers “Show cue” (WorkbenchHome.swift:537). It closes the panel (WorkbenchQuickPanel.swift:102) and replays a buttonless card with the same words (ClipboardReceipt.swift:140-147; CapturePanel.swift:1194-1230). It predates d677e65, which removed the cue's commands.
  • Change: delete the button and its parameter at all three call sites (including SurfaceGallery.swift:923). Also delete the gallery action (:3958), the registry entry, the dead revealHUD and its two checks. Copy again and Dismiss stay.
  • Check:
    • build, --check-feedback and check-surfaces.py pass;
    • grep finds no leftovers;
    • the renders show only Review text.
2. Change while recording
  • Problem: the panel editor opens already recording (QuickPanelLifecycle.swift:18-21), yet it shows Change (WorkbenchQuickPanel.swift:181), which only restarts the same wait (KeyboardCoach.swift:204-209). The Keyboard page shows only Cancel in this state (HomeTiles.swift:708-719).
  • Change: one leading slot shows Cancel while recording and Change otherwise. Turn off stays where it is.
  • Check: renders of both states.
Value before scope
  1. Outcome: fewer pointless choices. Evidence: the code paths.
  2. Simpler route: deletion.
  3. Owner: the shelf and the panel editor.
  4. Complexity: removes code.
  5. Verified by: renders and checks.

Grammar: Quality.

Refs #134, Refs #153

Build-ready record from the overnight lead session of 15 Oct 2026, verified against main edc15df by an independent skeptic per item. Implementation follows on a claude/* branch; this issue closes only after native acceptance.

Lingua principale
Swift
Stelle
0
Fork
1
Merge medio
8h 5m
PR unite (30g)
215

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Ship-Work/workbench

Tutte le issue di Ship-Work/workbench

Issue simili

Altre issue su Swift

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.