Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Quitting while narrating deletes the Snap & Talk take

Aperta
  • Qualcosa non va?
#330 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
3/5
Tempo stimato
1-2 giorni
Idoneità per principianti
45/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
macos, swift
Ambito
desktop

Direzione di ricerca

Start at applicationWillTerminate in main.swift (around line 764), which calls shutdown(), and follow it to cancelNarration() in ReadbackModel.swift (about 1250-1252) and the WAV deletion near lines 1063-1067. Compare with the Stop path that queues the take (about 1030-1058) and the launch transcription (about 1394-1402). Done means Quit keeps the take as .queued with no cue, --check-readback passes with a fake recorder, and short or quiet takes are still discarded. Check first whether the claude/* branch the issue mentions is already in progress.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug

Outcome: ⌘Q, logout or restart during Snap & Talk narration keeps the take, as Stop does. It is transcribed at the next launch.

Evidence (main edc15df)
  • applicationShouldTerminate (main.swift:736-755) does not count narration.
  • applicationWillTerminate calls shutdown() (:764), which calls cancelNarration() (ReadbackModel.swift:1250-1252). That deletes the pending WAV (:1063-1067).
  • Stop queues the take (:1030-1058), and launch transcribes queued takes (:1394-1402).
  • Dictate and bug reports keep their audio on Quit (AppModel.swift:1348-1359; BugReportModel.swift:565-568).
Change
  • Add a narrow NarrationRecording seam whose default builds AVAudioRecorder exactly as today.
  • Introduce keepNarration(cue:). shutdown() calls it without the no-speech cue.
  • The rule for discarding short or quiet takes is unchanged.
  • Add one sentence to docs/snap.md.
Acceptance

In --check-readback, with a fake recorder:

  • After a meter tick, shutdown() leaves no pending file, narration.wav keeps the same bytes, and the take is .queued with no cue.
  • A fresh model transcribes it to .ready.
  • A 0.2 s or −60 dB take is discarded.

A native ⌘Q check with a real microphone is still owed.

Value before scope
  1. Outcome: no silent data loss. Evidence: the traced path.
  2. Simpler route: Stop's existing path.
  3. Owner: ReadbackModel.
  4. Complexity: one test seam.
  5. Verified by: --check-readback.

Grammar: Quality.

Refs #63

Build-ready record from the overnight lead session of 15 Oct 2026, verified against main edc15df by an independent skeptic per item. Implementation follows on a claude/* branch; this issue closes only after native acceptance.

Lingua principale
Swift
Stelle
0
Fork
1
Merge medio
8h 5m
PR unite (30g)
215

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Ship-Work/workbench

Tutte le issue di Ship-Work/workbench

Issue simili

Altre issue su Swift

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.