Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Floating toolbar: honour Hide toolbar while drawing and preserve the active job

Aperta
  • Qualcosa non va?
#155 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
48/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
macos, swift
Ambito
desktop

Direzione di ricerca

Start by reading the visibility logic in FloatingToolbar.swift and how CapturePanel.swift combines toolbar preferences with active drawing and other activities. Reproduce the issue with the listed Draw steps, then trace how hide and restore interact with activity state and the separate live-job HUD. Done means the acceptance cases work without losing activity state or the last Stop/Cancel route, and native behavior is verified in the signed Preview.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug

Outcome and evidence

P2, reproduced. Hide toolbar leaves the toolbar visible while Draw is active.

Workbench Preview 2.3.0, build 20260928054038, source 00be555139f87d4557f48fcffc132b8621c251a2, unmodified source, macOS 26.5.1 (25F80), Apple M5, built-in display. Identity verified in the running app using Copy build details on 28 September 2026.

Reproduction

  1. Start Draw with no annotations.
  2. Use Window → Focus floating toolbar.
  3. Open the Draw menu and choose Hide toolbar.
  4. The toolbar remains visible with Stop drawing and mode chips.

A fresh screenshot and accessibility state confirmed the result. The test restored Show floating toolbar and stopped drawing with zero annotations. No board or artwork was changed.

Owner and bounded change

Source links below pin the earlier audited commit 9578d8cf; the relevant paths were checked against installed 00be5551 and the described behaviour is unchanged. Source findings and native observations are distinguished below.

FloatingToolbar.swift sets floatingToolbarVisible false, but CapturePanel.swift ORs the preference with active drawing, presentation, Persona and insertion before resolving visibility. The same conflict for Present/Persona is source-supported; native reproduction here covered Draw only.

Make an explicit hide request authoritative for the floating tools surface while preserving the underlying activity and a reachable restore action. Hide toolbar affects the tools surface only; a distinct live recording/processing HUD keeps its essential Stop/Cancel controls until that job ends. Do not make an offered toolbar Hide action silently fail because Draw, Present or Persona is active.

Acceptance

  • Hide/restore works in idle, Draw, Present and Persona, with current action state restored.
  • Hiding does not clear ink, end the scene, hide independent artwork or stop a timer.
  • One keyboard/menu-bar action restores controls without opening an unrelated page.
  • Recording/insertion retain Stop/Cancel through their live HUD and the existing quick controls/shortcut paths; hiding the tools surface does not stop the job or remove its last cancellation route.
  • Test persistence/relaunch as the product contract requires and verify native behaviour in the signed Preview.

Related: #56 and #134. Coordinate with the toolbar geometry fix.

Lingua principale
Swift
Stelle
0
Fork
1
Merge medio
8h 5m
PR unite (30g)
215

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Ship-Work/workbench

Tutte le issue di Ship-Work/workbench

Issue simili

Altre issue su Swift

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.