Hacktoberfest 2026: le issue che i maintainer hanno segnato per ottobre, aperte e adatte ai principianti. Sfoglia le issue Hacktoberfest

Floating toolbar: fit native window bounds to the full row in resting and expanded states

Aperta
  • Qualcosa non va?
#152 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub

I maintainer di solito rispondono entro 1 giorno

Nessuno ha ancora preso questa issue.

Valutazione

Difficoltà
4/5
Tempo stimato
3-5 giorni
Idoneità per principianti
45/100
Tipo di issue
Bug
Chiarezza
Abbastanza chiara
Stato di attività
Attiva
Stack tecnologico
macos, swift
Ambito
desktop

Direzione di ricerca

Start with CapturePanel.swift to trace the seeded and cached window sizes, then follow FloatingToolbar.swift's row measurement and ToolbarRow.swift's existing rounded chrome. Reproduce the resting and expanded states in the native app, recording content and window bounds through initial display and transitions. Done means a guard covering the production hosting/measurement chain and window frame catches clipping across the listed states, with the requested installed-app reproduction and fixed-state screenshot.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Descrizione

bug

Outcome and evidence

P1, reproduced. The floating toolbar cuts off labels, menu glyphs and rounded corners at its native window edges. People cannot reliably see or reach the controls.

Workbench Preview 2.3.0, build 20260928054038, source 00be555139f87d4557f48fcffc132b8621c251a2, unmodified source, macOS 26.5.1 (25F80), Apple M5, built-in display. Identity verified in the running app using Copy build details on 28 September 2026.

Native checks reproduced clipped resting Snap and Snap & Talk rows, and an expanded Present row with Prompts. The user's supplied screenshots independently show the same symptoms. Counterexample: expanded Snap and Snap & Talk could fit with rounded corners, so this is state-dependent.

Reproduction

  1. Show the floating toolbar with Keep open off.
  2. Select Snap, then Snap & Talk; move away and inspect the resting row.
  3. Switch to Present and reveal the row with Prompts, or turn Keep open on.
  4. Inspect both ends and all corners after the mode/expansion transition.

Resting screenshots were about 264 pixels wide and expanded Present about 800 pixels wide on this Retina display. Persisted panel sizes were 132 × 36 and 400 × 36 points, matching the host's seed sizes. This is evidence for a sizing investigation, not proof that one callback is the cause.

Owner and bounded change

Source links below pin the earlier audited commit 9578d8cf; the relevant paths were checked against installed 00be5551 and the described behaviour is unchanged. Source findings and native observations are distinguished below.

Fix production content measurement and native bounds through initial show and state changes. Preserve anchor direction and pointer stability. Adding another radius or a larger fixed width alone is unlikely to cover the observed transitions.

Acceptance

  • Record actual native/content bounds after layout; all visible and interactive content, border and corners fit.
  • Rest/reveal every mode at all supported anchors; include Present with Prompts and capture counts crossing 9→10 and 99→100.
  • Hover, Keep open, menus, keyboard focus, drag, active Stop/End labels and return from recovery settle without clipping or moving the intended action under the pointer.
  • Retest normal/larger controls, long labels, light/dark and relevant accessibility appearance settings.
  • Add a guard covering the full production hosting/measurement chain, including CapturePanel's wrapper and window frame. Extend the gallery or a focused native host fixture to fail when content exceeds the native bounds; standalone ToolbarRow renders alone do not establish this result.
  • Attach a synthetic installed-app reproduction and fixed-state screenshot with build identity.

Focused defect under #87 and #134. Coordinate native host changes with the explicit-hide request.

Lingua principale
Swift
Stelle
0
Fork
1
Merge medio
12h 29m
PR unite (30g)
201

Preparare l'ambiente

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Altre issue di Ship-Work/workbench

Tutte le issue di Ship-Work/workbench

Issue simili

Altre issue su Swift

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.